Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Fixes VPCSC Tests that did not conform to V2.0.0 client API #61

Merged
merged 5 commits into from Oct 8, 2020

Conversation

@sid-dinesh94
Copy link
Contributor

@sid-dinesh94 sid-dinesh94 commented Oct 8, 2020

Fixes #<issue_number_goes_here> 馃

Following the migration of the client to V2.0.0, these VPCSC specific tests started failing with syntax/typing errors.
This PR uses the keyword argument style for the client methods to fix the broken tests.

sid-dinesh94 added 3 commits Oct 8, 2020
Client now requires either one positional argument or individual keyword arguments for each call.
The fix in the previous commit worked for the test_async_batch_annotate_images_write_blocked test.
This commit updates other VPCSC tests to also work with the new client.
setting request to the dict didnt work.
@sid-dinesh94 sid-dinesh94 requested a review from as a code owner Oct 8, 2020
@google-cla google-cla bot added the cla: yes label Oct 8, 2020
@sid-dinesh94 sid-dinesh94 changed the title Fixes VPCSC Tests that did not conform to V2.0.0 client API fix: Fixes VPCSC Tests that did not conform to V2.0.0 client API Oct 8, 2020
@busunkim96 busunkim96 merged commit efed79a into googleapis:master Oct 8, 2020
8 checks passed
Loading
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants