fix: versions were not being updated in the root composer.json file - #281
Merged
Conversation
googlebot
added
the
cla: yes
Codecov Report
@@ Coverage Diff @@
## master #281 +/- ##
==========================================
+ Coverage 81.45% 81.68% +0.22%
==========================================
Files 24 24
Lines 2965 2964 -1
Branches 244 246 +2
==========================================
+ Hits 2415 2421 +6
+ Misses 538 531 -7
Partials 12 12
Continue to review full report at Codecov.
|
chingor13
approved these changes
Oct 8, 2019
dwsupplee
approved these changes
Oct 8, 2019
callmehiphop
reviewed
Oct 9, 2019
JustinBeckwith
approved these changes
Oct 9, 2019
bcoe
added
the
kokoro:force-run
kokoro-team
removed
the
kokoro:force-run
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Maps have different access patterns than objects, so when we switched to using a
new Map(), updates to the root composer file began failing.