Skip to content

fix(java): snapshot bumps should not autorelease - #282

Merged
bcoe merged 2 commits into
googleapis:masterfrom
chingor13:snapshot-labels
Oct 9, 2019
Merged

fix(java): snapshot bumps should not autorelease#282
bcoe merged 2 commits into
googleapis:masterfrom
chingor13:snapshot-labels

Conversation

@chingor13

Copy link
Copy Markdown
Contributor

Fixes #280
Fixes #272

@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Oct 8, 2019
@codecov

codecov Bot commented Oct 8, 2019

Copy link
Copy Markdown

Codecov Report

Merging #282 into master will increase coverage by 0.64%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #282      +/-   ##
==========================================
+ Coverage    80.8%   81.45%   +0.64%     
==========================================
  Files          24       24              
  Lines        2969     2965       -4     
  Branches      239      244       +5     
==========================================
+ Hits         2399     2415      +16     
+ Misses        559      538      -21     
- Partials       11       12       +1
Impacted Files Coverage Δ
src/releasers/java-yoshi.ts 89.04% <100%> (+6.46%) ⬆️
src/release-pr.ts 82.8% <0%> (+0.45%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 47fd671...5b39e50. Read the comment docs.

@bcoe bcoe left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@bcoe
bcoe merged commit eaf048e into googleapis:master Oct 9, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cla: yes This human has signed the Contributor License Agreement.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

unhandled rejection in Java tests Java: snapshot releases should not add autorelease label

3 participants