build: skip publishing private packages (#4995)

Fixes #4865
googleapis · Mar 14, 2023 · d982753 · d982753
1 parent c77f2b7
commit d982753
Show file tree

Hide file tree

Showing 3 changed files with 55 additions and 1 deletion.
diff --git a/packages/mono-repo-publish/src/main.ts b/packages/mono-repo-publish/src/main.ts
@@ -90,7 +90,6 @@ export function listChangedSubmodules(
   excludeGlobs: string[] = []
 ): string[] {
   const globs = excludeGlobs.map(glob => new mm.Minimatch(glob));
-  // Only checking for package.jsons in submodules that were changed
   // Not checking the top-level package.json
   let files = prFiles.filter(file =>
     file.match(/\/package\.json$|^package\.json$/)
@@ -123,6 +122,16 @@ function publish(
   execSync: typeof childProcess.execSync,
   rmSync: typeof fs.rmSync
 ): ExecutionOutput {
+  if (fs.existsSync(resolve(directory, 'package.json'))) {
+    const pkg = JSON.parse(
+      fs.readFileSync(resolve(directory, 'package.json'), 'utf-8')
+    );
+    if (pkg.private) {
+      return {
+        output: 'skipping publication ${directory}/package.json is private',
+      };
+    }
+  }
   const installCommand = stat(resolve(directory, 'package-lock.json'))
     ? 'ci'
     : 'i';

diff --git a/packages/mono-repo-publish/test/main.test.ts b/packages/mono-repo-publish/test/main.test.ts
@@ -160,4 +160,13 @@ describe('mono-repo publish', () => {
       'npm publish --access=public'
     );
   });
+
+  it('skips package if package is set to private', () => {
+    const output = core.publishSubmodules(
+      ['test/sample-private-package'],
+      false
+    );
+    console.log(output);
+    assert.deepStrictEqual(output, []);
+  });
 });
diff --git a/packages/mono-repo-publish/test/sample-private-package/package.json b/packages/mono-repo-publish/test/sample-private-package/package.json
@@ -0,0 +1,36 @@
+{
+    "name": "googleapis-samples",
+    "description": "The following samples show basic usage of various APIs.",
+    "repository": "google/google-api-nodejs-client",
+    "license": "Apache-2.0",
+    "private": true,
+    "engines": {
+      "node": ">=12.0.0"
+    },
+    "files": [
+      "**/*.js",
+      "!test/"
+    ],
+    "scripts": {
+      "prepare": "cd typescript && tsc && cd ..",
+      "test": "mocha"
+    },
+    "dependencies": {
+      "@google-cloud/local-auth": "^2.0.0",
+      "express": "^4.17.1",
+      "googleapis": "^112.0.0",
+      "googleapis-common": "^6.0.0",
+      "nconf": "^0.12.0",
+      "open": "^8.0.0",
+      "server-destroy": "^1.0.1",
+      "uuid": "^9.0.0"
+    },
+    "devDependencies": {
+      "chai": "^4.2.0",
+      "execa": "^5.0.0",
+      "mocha": "^9.0.0",
+      "nock": "^13.0.0",
+      "proxyquire": "^2.1.3",
+      "typescript": "^4.6.4"
+    }
+  }