Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(bazel): add include_samples to java_gapic_assembly_gradle_pkg #102

Merged
merged 2 commits into from
Jun 7, 2022

Conversation

eaball35
Copy link
Contributor

@eaball35 eaball35 commented Jun 7, 2022

BEGIN_COMMIT_OVERRIDE
feat(bazel): add include_samples to java_gapic_assembly_gradle_pkg
END_COMMIT_OVERRIDE

@eaball35 eaball35 requested a review from a team as a code owner June 7, 2022 19:22
@product-auto-label product-auto-label bot added the samples Issues that are directly related to samples. label Jun 7, 2022
@eaball35 eaball35 requested review from alexander-fenster and blakeli0 and removed request for blakeli0 and alexander-fenster June 7, 2022 19:23
@noahdietz
Copy link
Contributor

Hey @eaball35 I think you will need to update the baseline files as well to reflect this change. They are here and here.

@eaball35 eaball35 closed this Jun 7, 2022
@eaball35 eaball35 reopened this Jun 7, 2022
@eaball35 eaball35 enabled auto-merge (squash) June 7, 2022 21:23
@noahdietz noahdietz changed the title chore: include java samples feat(bazel): add include_samples to java_gapic_assembly_gradle_pkg Jun 7, 2022
@eaball35 eaball35 merged commit d1bc568 into main Jun 7, 2022
@eaball35 eaball35 deleted the eaball35-patch-1 branch June 7, 2022 21:35
@noahdietz
Copy link
Contributor

I should've asked to update the commit message to trigger release-please, I only updated the PR title without checking if auto-merge was enabled...sorry.

@eaball35
Copy link
Contributor Author

eaball35 commented Jun 7, 2022

I should've asked to update the commit message to trigger release-please, I only updated the PR title without checking if auto-merge was enabled...sorry.

Apologies I didn't mean to click automerge in the first place! Make sense, I'll need a new release of this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
samples Issues that are directly related to samples.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants