From 8f42efdb92d606a768a524517fe949c4f9112025 Mon Sep 17 00:00:00 2001 From: Mira Leung Date: Tue, 22 Jun 2021 13:26:26 -0700 Subject: [PATCH] fix(service.yaml): Remove allowlist restriction (#776) --- rules_java_gapic/java_gapic.bzl | 14 +------------- 1 file changed, 1 insertion(+), 13 deletions(-) diff --git a/rules_java_gapic/java_gapic.bzl b/rules_java_gapic/java_gapic.bzl index 03b4467a3c..65cb3617f7 100644 --- a/rules_java_gapic/java_gapic.bzl +++ b/rules_java_gapic/java_gapic.bzl @@ -14,7 +14,6 @@ load("@rules_gapic//:gapic.bzl", "proto_custom_library", "unzipped_srcjar") -SERVICE_YAML_ALLOWLIST = ["clouddms", "cloudkms", "datastream", "pubsub"] NO_GRPC_CONFIG_ALLOWLIST = ["library"] def _java_gapic_postprocess_srcjar_impl(ctx): @@ -144,19 +143,8 @@ def _java_gapic_srcjar( if gapic_yaml: file_args_dict[gapic_yaml] = "gapic-config" - # Check the allow-list. - # TODO: Open this up after mixins are published, and gate on - # the allowlisted "mixed-in" APIs present in Java. if service_yaml: - service_yaml_in_allowlist = False - for keyword in SERVICE_YAML_ALLOWLIST: - if keyword in service_yaml: - service_yaml_in_allowlist = True - break - if service_yaml_in_allowlist: - file_args_dict[service_yaml] = "api-service-config" - else: - fail("Service.yaml is no longer supported in the Java microgenerator") + file_args_dict[service_yaml] = "api-service-config" output_suffix = ".srcjar" opt_args = []