From a77af8b291b7cc9bd138d62ac46730eaa4b3509a Mon Sep 17 00:00:00 2001 From: Chanseok Oh Date: Wed, 8 Sep 2021 16:20:46 -0400 Subject: [PATCH 1/2] Fix dev doc --- DEVELOPMENT.md | 22 +++++++++++++++++++--- 1 file changed, 19 insertions(+), 3 deletions(-) diff --git a/DEVELOPMENT.md b/DEVELOPMENT.md index 8cd12949a0..f93c76c8e2 100644 --- a/DEVELOPMENT.md +++ b/DEVELOPMENT.md @@ -15,13 +15,13 @@ ## Running the Plugin 1. Clone [googleapis](https://github.com/googleapis/googleapis) and - [gapic-showcase](https://github.com/googleapis/gapic-showcase/) and install - protoc. + [gapic-showcase](https://github.com/googleapis/gapic-showcase/). 2. Copy the protos from Showcase into googleapis/google/showcase. ```sh - cp gapic-showcase/schema/google/showcase/v1beta1 googleapis/google/showcase/v1beta + mkdir googleapis/google/showcase + cp -r gapic-showcase/schema/google/showcase/v1beta1 googleapis/google/showcase/v1beta1 ``` 3. Add the new microgenerator rules to the protobuf directory's `BUILD.bazel` @@ -33,6 +33,22 @@ # Existing rules here. "java_gapic_assembly_gradle_pkg", "java_gapic_library", + "java_proto_library", + "proto_library_with_info", + ) + + proto_library_with_info( + name = "showcase_proto_with_info", + deps = [ + ":showcase_proto", + ], + ) + + java_proto_library( + name = "showcase_java_proto", + deps = [ + "showcase_proto", + ], ) # This should either replace the existing monolith target or have a unique name From 1a0fdfaa5e33b6685ba1ce7194004543bc8e7ff9 Mon Sep 17 00:00:00 2001 From: Chanseok Oh Date: Thu, 9 Sep 2021 16:41:04 -0400 Subject: [PATCH 2/2] Clarify BUILD.bazel location --- DEVELOPMENT.md | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/DEVELOPMENT.md b/DEVELOPMENT.md index f93c76c8e2..ce5fec73c5 100644 --- a/DEVELOPMENT.md +++ b/DEVELOPMENT.md @@ -24,8 +24,8 @@ cp -r gapic-showcase/schema/google/showcase/v1beta1 googleapis/google/showcase/v1beta1 ``` -3. Add the new microgenerator rules to the protobuf directory's `BUILD.bazel` - file as follows: +3. Add the new microgenerator rules to + `googleapis/google/showcase/v1beta1/BUILD.bazel` file as follows: ```python load(