Navigation Menu

Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(python): fix formatting issue in noxfile.py.j2 #1241

Merged
merged 1 commit into from Oct 12, 2021

Conversation

parthea
Copy link
Contributor

@parthea parthea commented Oct 8, 2021

PR #1237 fixed a formatting issue in noxfile.py.j2 however after running the latest post processor image, there is still a syntax issue.

Here are the steps that I ran to validate this fix.

Checkout the branch for this PR and run the following:

docker build -t testlogging -f docker/owlbot/python/Dockerfile .

In the python-logging repo, run

docker run --user $(id -u):$(id -g) --rm -v $(pwd):/repo -w /repo testlogging

@parthea parthea requested a review from a team as a code owner October 8, 2021 23:58
@google-cla google-cla bot added the cla: yes This human has signed the Contributor License Agreement. label Oct 8, 2021
@parthea parthea merged commit 0e85ed6 into master Oct 12, 2021
@parthea parthea deleted the fix-formatting-issue-in-noxfile branch October 12, 2021 11:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants