Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: fix Node.js TOC for cloud-rad #822

Merged
merged 1 commit into from Oct 21, 2020
Merged

chore: fix Node.js TOC for cloud-rad #822

merged 1 commit into from Oct 21, 2020

Conversation

fhinkel
Copy link
Contributor

@fhinkel fhinkel commented Oct 21, 2020

No description provided.

@fhinkel fhinkel requested a review from a team as a code owner October 21, 2020 14:38
@google-cla google-cla bot added the cla: yes This human has signed the Contributor License Agreement. label Oct 21, 2020
@bcoe
Copy link
Contributor

bcoe commented Oct 21, 2020

I think this will result in 100 PRs without context tomorrow morning, due to landing this on the same day.

@SurferJeffAtGoogle any advice to make this less of a pain?

@SurferJeffAtGoogle
Copy link
Contributor

SurferJeffAtGoogle commented Oct 21, 2020 via email

@fhinkel
Copy link
Contributor Author

fhinkel commented Oct 21, 2020

Or we can wait a few days before we merge this? Sorry for the confusion. Of course I don't get a sed regex right on the first try.

@bcoe
Copy link
Contributor

bcoe commented Oct 21, 2020

@SurferJeffAtGoogle @fhinkel why don't we just make sure at the end of the day today, that there are no PRs open with the title "Changes due to synthtool".

Then we can merge this, and tomorrow morning rename all the PRs?

@SurferJeffAtGoogle
Copy link
Contributor

SurferJeffAtGoogle commented Oct 21, 2020 via email

@bcoe bcoe merged commit 901ddd4 into master Oct 21, 2020
@bcoe bcoe deleted the fhinkel-cloud-rad branch October 21, 2020 16:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants