Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Already on GitHub? Sign in to your account

Update clock dart packaged app example for a modern dart. #190

Merged
merged 1 commit into from Apr 4, 2014

Conversation

Projects
None yet
2 participants

tapted commented Jan 24, 2014

This change allows the clock to run in Dartium m31, or in Chrome,
without changes.

Changes:
dart2js no longer accepts --disallow-unsafe-eval
window.requestLayoutFrame is now scheudleMicrotask from dart:async.
Date is now DateTime
List.filter is now List.removeWhere
String.charCodeAt is now String.codeUnitAt
js/interop stuff no longer required

Bugfix: Fix numbers not showing up at all when first opened, e.g., at
exactly 4pm and now.minute == 0.

Review URL: https://codereview.appspot.com/56440043

Update clock dart packaged app example for a modern dart.
This change allows the clock to run in Dartium m31, or in Chrome,
without changes.

Changes:
 dart2js no longer accepts --disallow-unsafe-eval
 window.requestLayoutFrame is now scheudleMicrotask from dart:async.
 Date is now DateTime
 List<E>.filter is now List<E>.removeWhere
 String.charCodeAt is now String.codeUnitAt
 js/interop stuff no longer required

Bugfix: Fix numbers not showing up at all when first opened, e.g., at
exactly 4pm and now.minute == 0.

Review URL: https://codereview.appspot.com/56440043

tapted referenced this pull request in nelsonsilva/chrome-app-samples Jan 28, 2014

benfredwells added a commit that referenced this pull request Apr 4, 2014

Merge pull request #190 from tapted/update-dart-clock-example
Update clock dart packaged app example for a modern dart.

@benfredwells benfredwells merged commit 8bc9728 into googlearchive:master Apr 4, 2014

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment