Remove all references to a listener (leak fix) #1

Closed
wants to merge 1 commit into
from

Conversation

Projects
None yet
2 participants
@rom1v

rom1v commented Feb 3, 2014

When we remove a listener, we need to remove all its references. One
was missing in BaseCastManager.

This had the side-effect to call several times the listener callbacks
when the listener was removed then re-added.

Remove all references to a listener (leak fix)
When we remove a listener, we need to remove *all* its references. One
was missing in BaseCastManager.

This had the side-effect to call several times the listener callbacks
when the listener was removed then re-added.
@naddaf

This comment has been minimized.

Show comment
Hide comment
@naddaf

naddaf Feb 3, 2014

Member

Thanks for reporting it. I fixed the issue (it was also present in the DataCastManager). To contribute, please follow the steps in CONTRIBUTING.md

Member

naddaf commented Feb 3, 2014

Thanks for reporting it. I fixed the issue (it was also present in the DataCastManager). To contribute, please follow the steps in CONTRIBUTING.md

@naddaf naddaf closed this Feb 3, 2014

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment