Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CLS is not reported on first hidden if the value is still zero #14

Closed
philipwalton opened this issue May 3, 2020 · 0 comments · Fixed by #16
Closed

CLS is not reported on first hidden if the value is still zero #14

philipwalton opened this issue May 3, 2020 · 0 comments · Fixed by #16
Assignees

Comments

@philipwalton
Copy link
Member

Pages with a CLS value of 0 still need to report that value when the page is first hidden. However, the current callback logic won't fire a callback if the delta is 0 and the metric is not final.

This logic should be updated to also check if no previous value exists (to allow for first-time reporting of 0-delta metrics).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant