Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cannot reassign a Pipeline to use a specific push task queue #33

Closed
dalippa opened this issue Jan 28, 2015 · 3 comments

Comments

@dalippa
Copy link

commented Jan 28, 2015

The only place I saw where this could be "overridden" is in the start() method, which works on the local dev_appserver but not with certain Mapreduce jobs on a deployed GAE environment.

It would seem this would need to be able to be added to with_params() to override the default task queue, along with the default target.

@tkaitchuck

This comment has been minimized.

Copy link
Contributor

commented Feb 13, 2015

It depends what you mean by overriding the queue. This: https://github.com/GoogleCloudPlatform/appengine-mapreduce/blob/de86c28ae80877b3b4ba0d5e90eca63ae6100bd2/python/test/mapreduce/parameters_test.py#L106
works. I assume you mean you want the pipeline off the default queue entirely even for the wrapping pipeline. I don't personally know the python code well enough to definitively state if that is possible. But if you want to change it feel free to send a pull request.

@dalippa

This comment has been minimized.

Copy link
Author

commented Feb 13, 2015

I spoke with Google, and apparently the queue_name is not propagated to child pipelines. I had to subclass PipelineBase, MapreducePipeline, and MapperPipeline - and override the start() method there.

No pull request is absolutely needed, though it might be nice to have a way for child pipelines to inherit the task queues of their parents.

@tkaitchuck

This comment has been minimized.

Copy link
Contributor

commented Feb 15, 2015

Ah, ok. That makes sense. Closing this in favor of GoogleCloudPlatform/appengine-pipelines#17

@tkaitchuck tkaitchuck closed this Feb 15, 2015

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.