Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

PERFORM LAST: go through all dialect functions and check for missed overrides #13

Closed
ChengyuanZhao opened this issue Jan 23, 2019 · 1 comment
Closed

PERFORM LAST: go through all dialect functions and check for missed overrides #13

ChengyuanZhao opened this issue Jan 23, 2019 · 1 comment
Assignees
@ChengyuanZhao

Comments

@ChengyuanZhao
Copy link
Member

Because there are literally dozens and dozens of dialect functions, this check should be done at the end to make sure we haven't missed any implementations or overrides.

this involves checking each function in the base dialect against our dialect.
@ChengyuanZhao ChengyuanZhao self-assigned this Jan 23, 2019
@meltsufin
Copy link
Member

Had been done.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ChengyuanZhao ChengyuanZhao

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@meltsufin @ChengyuanZhao