Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Element Shape (ELSH) Axis #15

Closed
felipesanches opened this issue Mar 11, 2022 · 5 comments · Fixed by #56
Closed

Add Element Shape (ELSH) Axis #15

felipesanches opened this issue Mar 11, 2022 · 5 comments · Fixed by #56
Labels
--new-axis New variable axis definition
Milestone
Q4 2022

Comments

@felipesanches
Copy link
Member

  • Description: "Controls the shape of the element"
  • Range: 0.0 - 16.0

Fonts to be onboarded that have this axis:
@davelab6
Copy link
Member

Per discussion with Evan and others, we want to define this as 0.0..100.0 to allow for future fonts with more shapes

@vv-monsalve
Copy link
Contributor

vv-monsalve commented Jul 27, 2022 •
edited by RosaWagner
Loading

Element Shape

#Element Shape, based on https://github.com/rosettatype/handjet
tag: "ELSH" 
display_name: "Element Shape"
min_value: 0.0
default_value: 0.0
max_value: 100.0
precision: -1
description: 
    "Controls the shape of the element"

Handjet-ESHP-animation_word

@davelab6
Copy link
Member

Agreed -1 precision is good

@vv-monsalve vv-monsalve mentioned this issue Jul 27, 2022
Merged
@chrissimpkins chrissimpkins linked a pull request Aug 9, 2022 that will close this issue
Add ELSH custom axis #56
Merged
@chrissimpkins
Copy link
Member

Axis tag will be changed to ELSP

@chrissimpkins chrissimpkins changed the title Add Element Shape (ESHP) Axis Add Element Shape (ELSP) Axis Aug 10, 2022
@davelab6 davelab6 mentioned this issue Aug 15, 2022
Closed
@chrissimpkins chrissimpkins added this to the Q4 2022 milestone Sep 21, 2022
@chrissimpkins chrissimpkins added the --new-axis New variable axis definition label Sep 21, 2022
@RosaWagner RosaWagner changed the title Add Element Shape (ELSP) Axis Add Element Shape (ELSH) Axis Sep 28, 2022
@RosaWagner
Copy link
Contributor

Evan and Dave confirmed ELSH and ELGR

@vv-monsalve vv-monsalve mentioned this issue Jul 26, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
--new-axis New variable axis definition
Projects
None yet
Milestone
Q4 2022
Development

Successfully merging a pull request may close this issue.

Add ELSH custom axis vv-monsalve/axisregistry
5 participants
@felipesanches @davelab6 @chrissimpkins @RosaWagner @vv-monsalve