New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Include source context in preparation_logs #74

Open
davelab6 opened this Issue Jun 28, 2018 · 1 comment

Comments

2 participants
@davelab6
Member

davelab6 commented Jun 28, 2018

http://35.225.170.228/report/75a1bc73-8f68-4b3e-b751-8aea4172fc93 doesn't tell us where the source was in the preparation_logs section, which makes it tricker to take action on the report.

(I know the source is the CSV parser's URL, because I opened that page from that cell in the dashboard homepage table, but I can't tell this from the report page itself :)

@graphicore

This comment has been minimized.

Collaborator

graphicore commented Jun 28, 2018

I'll think of it! We have some more information stored to show about the source as well.

One report can have many sources, if the sources produce the same input for font bakery (by sha256 hash and environment version). We could remove that (possible) many-to-one relationship by creating more (potentially equal) reports though. I'm not sure anymore, if that hashing/environment version thing is a good idea to pursue though, also because of that thing (we talked about it before) that our font-bakery specification is not idempotent.
Also, it's hard to say if this, as an optimization, is worth the effort. I see the most potential when we issue a re-run of the whole collection or also of one source when only a couple of families have changed and font-bakery has not changed. Then, shortcutting like this would reduce the run time and computing power needed a lot.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment