Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.
Sign upCheck NAME id 5 (version) is correct #553
Comments
davelab6
assigned
vitalyvolkov
Jun 24, 2015
This comment has been minimized.
Show comment
Hide comment
This comment has been minimized.
adrientetar
Jun 24, 2015
Contributor
Although three numbers is conventionally used these days, it wasn’t always the case and spec says any numbers count is compliant for version minor. Also semicolon is not a requirement, anything that’s not a number terminates the number string. Termination is also optional.
What should really be enforced is Version X.Y where X and Y are any number of integers. If anything follows in the string that’s not numbers, it is ignored for the test.
|
Although three numbers is conventionally used these days, it wasn’t always the case and spec says any numbers count is compliant for version minor. Also semicolon is not a requirement, anything that’s not a number terminates the number string. Termination is also optional. |
This comment has been minimized.
Show comment
Hide comment
This comment has been minimized.
|
I agree, updated |
added a commit
that referenced
this issue
Jun 26, 2015
vitalyvolkov
assigned
davelab6
and unassigned
vitalyvolkov
Jun 26, 2015
This comment has been minimized.
Show comment
Hide comment
This comment has been minimized.
|
@davelab6 done |
This comment has been minimized.
Show comment
Hide comment
This comment has been minimized.
davelab6
Feb 2, 2016
Member
@adrientetar since the head table doesn't allow for MAJOR.MINOR.PATCH I think a MAJOR.MINOR numbering scheme is best.
|
@adrientetar since the |
davelab6 commentedJun 24, 2015
As per google/fonts#63 fb must check the NAME id 5 string value follows the pattern
Version X.Y