-
Notifications
You must be signed in to change notification settings - Fork 72
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[builder] Roman/Italic variation issue in Indesign when stat in config.yaml #297
Comments
This is the config.yaml, maybe I am missing something:
|
Thanks for the detailed issue. What happens if you ttx the stat tables then diff them?
|
Perhaps the issue doesn't involve the STAT, maybe it's the fvar instances. Both the auto stat and your gen-stat script will update the fvar instances so they include postscript names, https://github.com/RosaWagner/Texturina/blob/master/sources/gen_stat.py#L81-L95 Instead of just dumping the 'STAT' also do the 'fvar' so, |
in fvar table, in each instances, there is no Postscript name line in the bad file |
|
With better view of 1st column
|
Last time I checked, InDesign still needed And also |
Thanks @thlinard. So, @m4rc1e, can you update the builder to ensure those 2 pieces of data are always included, and @felipesanches please can you add a fontbakery FAIL check if they aren't found? |
Fine by me, I'll add it next week. |
Awesoooome |
In conversation in a still private project, @tiroj commented:
I see the point in providing cases to support the resolution of this at Adobe's applications level, nevertheless, this would imply to publish fonts that would bug in Indesign and therefore in the meanwhile probably to receive many complaints about it. |
Personally, I would like Indesign to work without the need for us to add fvar postscript instance names and nameID 25. However, our module stat.py can already generate these names, https://github.com/googlefonts/gftools/blob/main/Lib/gftools/stat.py#L260-L290 so adding it isn't such a big deal, just requires some rewiring. |
The nameID 25 issue in InDesign is not new, I doubt that more proof is needed. I'd drawn Marc's attention to this problem in June 2020 (moreover, the description of the problem is incomplete, adding nameID will not be enough, you also need I would add that, although I can understand someone wanting to do without this complication by Adobe (which is not necessary for Illustrator, for example, but it seems the development teams don't speak to each other at Adobe), but in view of the speed at which Adobe fixes its bugs in InDesign, it's better to continue to implement it. Anyway, it looks like @davelab6 agrees. |
BTW, FYI, Cascadia Code release 2102.03 implemented a workaround for Word for Mac:
With this change, nameID 4 + 17 = nameID 6 = nameID 25 (in the variation of a space or a hyphen). It doesn't seem enough, but after discussing it with Aaron Bell, he thinks this is the right thing to do to prepare for the Word for Mac fix that should arrive this month (which should allow using VFs in Word for Mac, which isn't possible currently). |
Hi, I tested Office for Mac version 16.46 (February 2021 update) today (not sure if there is the same patch for Office for Windows). According to my tests (dummy fonts with fake The results are quite… surprising, and sometimes gives the same result as the For example, Word lists the following styles for Literata:
(I believe the double Bold entries are caused by the lack of For older VFs (first VFs released by Google Fonts, with buggy STAT table), the fonts are completely unusable (text and font name completly garbled). TL;DR: |
What we’re finding is that the format of fvar STIXTwoText-MediumItalic (which follows the spec for name ID 6 and corresponds directly to the name ID 6 in the static font family) does not affect the InDesign behaviour, but STIXTWOTextItalic-Medium does. This means that InDesign not only requires fvar @khaledhosny and I suspect that what it actually happening is that InDesign does not actually require the fvar So this seems not simply a matter of an incorrect assumption about the needed presence of what the OT spec identifies as optional data, that we may decide as an industry to work around by providing the data, but an actual bug in InDesign’s underlying code that we would be foolish to work around since the data that would require breaks the normal rules for constructing PS font names, makes fvar |
Yes, the part before the hyphen must be equal to nameID 25, and, we agree on that, this is not the normal rules for constructing PS font names.
Of course InDesign is bugged! Illustrator works correctly without that! But the workaround is not "foolish": without it, the fonts don't work. So you can get into a show of strength with Adobe and wait and see who gives in first, but in the meantime, it's the users who suffer. |
Yes, users suffer because of bugs, and the way to stop their suffering is to fix the bugs. Sorry, but I have a long experience of the unintended consequences of font makers working around bugs and of bugs hence become de facto undocumented standards that then can never be fixed. |
This story is well known. But has the show of "strength" by font designers ever changed software vendors' minds? |
I don’t think it is a matter of a contest of strength. Adobe have always needed help implementing OpenType: I and others have had to explain a lot of things to various product groups at Adobe over the years, very often with the encouragement of Adobe’s own type group. It has never been helped by font makers rushing to work around the bugs. InDesign CC now pushes updates so frequently, that there isn’t the old excuse that bug fixes will take too long to propagate. |
I also think that if you can communicate with the InDesign development team, that's what will give the best results (and if, at the same time, you could point out to them that the interface of OpenType features in the Character panel tab, which has not changed for 20 years, is a bit dated, and that they could usefully take inspiration from which was made for a product named Photoshop – maybe they heard about it –, that will be good!). |
I am in touch with an InDesign product manager about this issue. The InDesign developers obviously understand font families when it comes to static fonts, so I am not unhopeful that that they will be able to understand families when it comes to variable fonts. |
But Adobe Technical Note states that:
Since this is the name ID 25 replacement, it follows that name ID 25 should be the same as the family name, i.e. |
We (Adobe) have an open issue about this about making InDesign act like Illustrator. I'll add a link to this thread and all the others I can find since this seems to keep coming up over and over. |
Photoshop should be included as well. Before version 15.1.2, InDesign also requested AxisValue in format 2 only, but it has been fixed since then. According to my last tests, Photoshop and InDesign now have roughly the same behavior (need So if you could inform the Photoshop development team as well, that would be great. |
In the STIX Two Text variable fonts (v2.12 going live probably some time today), we found we could obtain correct behaviour in InDesign by only providing name ID25 entries: we didn’t need to also add the fvar |
@punchcutter I'm curious if you have any updates on this :) |
@davelab6 Nothing to report, but it hasn't been forgotten. I pinged the team again on your behalf. |
@punchcutter Any update on this Zachary? I am wondering if this or similar name issue might also be playing a role in this InDesign variable font printing issue reported by Kris Sowersby that only affects some fonts: |
Nothing meaningful to report right now, but we are engaged with the InDesign team about all of this. |
As Khaled mentioned in #297 (comment), a nameID25 with the font name only should be sufficient. But last testing was not conclusive, nameID25 of the Roman and the Italic still need to be different. But the good news that we didn't know is that the case of having "FontName" and "FontNameItalic" works. We could upgrade gftools to stop generating a "Roman" particule to the upright's nameID25. I just tested this and attach the test case here. |
I just checked with the zip file posted above in the latest Indesign (18.1): Roman and Italic with identical name ID 25: Italic doesn't even show up (Font2). So, nothing changed. |
Just commenting to say this is still a problem, and it is also a related problem in Illustrator. https://typo.social/@arrowtype/110430680157544757 Luckily, the workaround seems to fix the font in both apps. |
The italic is going back to roman when using the weight slider in Indesign — but only when there is the stat in the config.yaml.
texturina-italicissue.mov
These are my different test:
See: https://github.com/RosaWagner/Texturina/tree/master/fonts/variable
See: https://github.com/RosaWagner/Texturina/tree/master/fonts-builder/variable
See: https://github.com/RosaWagner/Archivo/tree/master/fonts/variable
The text was updated successfully, but these errors were encountered: