Modernize tooling; upgrade to designspace v5. #41
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pip-tools has been used to generate requirements.txt from a much smaller requirements.in; the actual font build depends only on fontmake and gftools, and works with the latest versions of both. Since designspace v5 supports multiple axes and multiple variable fonts, there is now a single designspace file which defines both the Roman and Italic variable fonts, along with their three weight instances. (I have also normalized the axis values for the weight axis; as far as I can tell this causes no visible change.) The postprocessing in build.sh no longer creates a dummy DSIG table, since this is no longer required by Google Fonts. Likewise, it also no longer drops the MVAR table to work around a bug in earlier versions of Windows 10. I have bumped the font minor version number to 1 to acknowledge this change in tooling. Due to missing sources, I am unable to rebuild the specimen PDFs.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
pip-tools has been used to generate requirements.txt from a much smaller requirements.in; the actual font build depends only on fontmake and gftools, and works with the latest versions of both.
Since designspace v5 supports multiple axes and multiple variable fonts, there is now a single designspace file which defines both the Roman and Italic variable fonts, along with their three weight instances. (I have also normalized the axis values for the weight axis; as far as I can tell this causes no visible change.)
The postprocessing in build.sh no longer creates a dummy DSIG table, since this is no longer required by Google Fonts (fonttools/fontbakery#3398, googlefonts/gftools#564). Likewise, it also no longer drops the MVAR table to work around a bug in earlier versions of Windows 10 (fonttools/fontbakery#3412, fonttools/fontbakery#3413).
I have bumped the font minor version number to 1 to acknowledge this change in tooling. Due to missing sources, I am unable to rebuild the specimen PDFs.
Finally, I've removed the obsolete "glyphs data" files; these were always marked as transitional, and are certainly not used in the build process.