Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sdks/cpp needs unit tests #905

Open
devjgm opened this issue Jul 13, 2019 · 8 comments
Open

sdks/cpp needs unit tests #905

devjgm opened this issue Jul 13, 2019 · 8 comments
Assignees
Labels
area/tests Unit tests, e2e tests, anything to make sure things don't break awaiting-maintainer Block issues from being stale/obsolete/closed good first issue These are great first issues. If you are looking for a place to start, start here! help wanted We would love help on these issues. Please come help us! kind/feature New features for Agones

Comments

@devjgm
Copy link
Contributor

devjgm commented Jul 13, 2019

Is your feature request related to a problem? Please describe.

The C++ code in sdks/cpp/ doesn't have any unit tests, so there's no way to verify that an of it works. This makes it difficult for anyone to contributed a change/fix to the code base, because there's no way to prove that the code works (before or) after the change.

Describe the solution you'd like

All the C++ files in sdks/cpp should have a foo_test.cc that corresponds to foo.h and foo.cc. The unit tests should be implemented using Google Test (https://github.com/google/googletest)

Describe alternatives you've considered

None. There's no alternative to unit tests :-)

Additional context

There are other unit testing frameworks, but I believe Google Test is by far the most common for C++, and it's the one required for Google C++ code.

@devjgm devjgm added the kind/feature New features for Agones label Jul 13, 2019
@markmandel
Copy link
Member

Yes please! We definitely need someone with C++ experience to write this 👍

@markmandel markmandel added the area/tests Unit tests, e2e tests, anything to make sure things don't break label Jul 13, 2019
@markmandel markmandel added help wanted We would love help on these issues. Please come help us! good first issue These are great first issues. If you are looking for a place to start, start here! labels Jul 28, 2022
@github-actions
Copy link

'This issue is marked as Stale due to inactivity for more than 30 days. To avoid being marked as 'stale' please add 'awaiting-maintainer' label or add a comment. Thank you for your contributions '

@github-actions github-actions bot added the stale Pending closure unless there is a strong objection. label Apr 15, 2023
@markmandel markmandel removed the stale Pending closure unless there is a strong objection. label Apr 18, 2023
@markmandel
Copy link
Member

We should probably do this at some point.

@github-actions
Copy link

github-actions bot commented Jun 1, 2023

'This issue is marked as Stale due to inactivity for more than 30 days. To avoid being marked as 'stale' please add 'awaiting-maintainer' label or add a comment. Thank you for your contributions '

@github-actions github-actions bot added the stale Pending closure unless there is a strong objection. label Jun 1, 2023
@markmandel markmandel added awaiting-maintainer Block issues from being stale/obsolete/closed and removed stale Pending closure unless there is a strong objection. labels Jun 7, 2023
@markmandel
Copy link
Member

Adding awainting-maintainer label, since we really should do this.

@zedGGs
Copy link

zedGGs commented Feb 7, 2024

Heey @markmandel, would be good idea to add required tests,
I can do something about that, if u think that's okey u can assign me

@markmandel
Copy link
Member

@zedGGs please go for it! Consider yourself assigned. Let us know if you have any questions here about the framework in place for SDKs, or in #development on Slack!

@zedGGs
Copy link

zedGGs commented Feb 10, 2024

@markmandel awesome stuff ! thanks, sure,
Im gonna add pr !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/tests Unit tests, e2e tests, anything to make sure things don't break awaiting-maintainer Block issues from being stale/obsolete/closed good first issue These are great first issues. If you are looking for a place to start, start here! help wanted We would love help on these issues. Please come help us! kind/feature New features for Agones
Projects
None yet
Development

No branches or pull requests

3 participants