Add Sidecar log level parameter to GS specification #1007

aLekSer · 2019-08-21T13:44:37Z

Add ability to specify logrus log level in yaml configuration and apply this log level on GameServer creation step.

Closes #971 .

aLekSer · 2019-08-21T13:45:20Z

What is left: documentation update and UT.

agones-bot · 2019-08-21T13:53:06Z

Build Failed 😱

Build Id: 0d2740fa-f270-417d-9191-c6db48c68592

To get permission to view the Cloud Build view, join the agones-discuss Google Group.

aLekSer · 2019-08-21T14:23:57Z

Build failed because I should have performed make gen-api-docs

Step #15 - "tests": includes/website.mk:96: recipe for target 'test-gen-api-docs' failed

agones-bot · 2019-08-21T16:33:55Z

Build Succeeded 👏

Build Id: 8723c226-c6d1-4a63-9c26-21833df2e505

The following development artifacts have been built, and will exist for the next 30 days:

image: gcr.io/agones-images/agones-controller:1.0.0-0402062
image: gcr.io/agones-images/agones-sdk:1.0.0-0402062
image: gcr.io/agones-images/agones-ping:1.0.0-0402062
Linux C++ SDK (build): agonessdk-1.0.0-0402062-linux-arch_64.tar.gz
SDK Server: agonessdk-server-1.0.0-0402062.zip

A preview of the website (the last 30 builds are retained):

https://0402062-dot-preview-dot-agones-images.appspot.com/

To install this version:

git fetch https://github.com/GoogleCloudPlatform/agones.git pull/1007/head:pr_1007 && git checkout pr_1007
helm install install/helm/agones --namespace agones-system --name agones --set agones.image.tag=1.0.0-0402062

markmandel · 2019-08-21T18:21:58Z

pkg/apis/agones/v1/gameserver.go

@@ -135,6 +135,8 @@ type GameServerSpec struct {
 	Health Health `json:"health,omitempty"`
 	// Scheduling strategy. Defaults to "Packed".
 	Scheduling apis.SchedulingStrategy `json:"scheduling,omitempty"`
+	// LogLevel specifies the log level for gameserver sidecar.
+	LogLevel string `json:"loglevel,omitempty"`


Random thought: Is "loglevel" too generic? Considering it's just for the sdk sidecar - should we pick a name that's more specific? sdk-server-loglevel (seems long), not sure what the right answer is here, figured I would ask the question first.

Just wondering if the name might be confusing.

yes, you are right, that would suit better.

agones-bot · 2019-08-22T17:33:06Z

Build Failed 😱

Build Id: 1c8ebc65-0e9b-4acb-8802-a3d4997cdf23

To get permission to view the Cloud Build view, join the agones-discuss Google Group.

agones-bot · 2019-08-22T17:47:10Z

Build Succeeded 👏

Build Id: ff00d479-51e0-4d7f-b23d-ef6e6e874236

The following development artifacts have been built, and will exist for the next 30 days:

image: gcr.io/agones-images/agones-controller:1.0.0-d9987ac
image: gcr.io/agones-images/agones-sdk:1.0.0-d9987ac
image: gcr.io/agones-images/agones-ping:1.0.0-d9987ac
Linux C++ SDK (build): agonessdk-1.0.0-d9987ac-linux-arch_64.tar.gz
SDK Server: agonessdk-server-1.0.0-d9987ac.zip

A preview of the website (the last 30 builds are retained):

https://d9987ac-dot-preview-dot-agones-images.appspot.com/

To install this version:

git fetch https://github.com/GoogleCloudPlatform/agones.git pull/1007/head:pr_1007 && git checkout pr_1007
helm install install/helm/agones --namespace agones-system --name agones --set agones.image.tag=1.0.0-d9987ac

aLekSer · 2019-08-22T18:34:37Z

Flaky E2E test:

Step #20: --- FAIL: TestFleetScaleUpEditAndScaleDown (0.01s)
Step #20: --- FAIL: TestFleetScaleUpEditAndScaleDown/Use_fleet_Patch_false (156.24s)
Step #20: fleet_test.go:120: 
Step #20: Error Trace:	fleet_test.go:120
Step #20: Error: Expected nil, but got: &errors.errorString{s:"timed out waiting for the condition"}
Step #20: Test: TestFleetScaleUpEditAndScaleDown/Use_fleet_Patch_false

markmandel · 2019-08-22T23:55:03Z

site/content/en/docs/Reference/gameserver.md

@@ -49,6 +49,8 @@ spec:
    # Minimum consecutive failures for the health probe to be considered failed after having succeeded.
    # Defaults to 3. Minimum value is 1
    failureThreshold: 3
+  # SdkServer Log Level configuration. Could be any of panic, fatal, error, warn, warning, info, debug and trace. Defaults to info


we should feature wrap these items.

markmandel · 2019-08-22T23:55:10Z

install/yaml/install.yaml

@@ -860,6 +882,17 @@ spec:
                            type: integer
                            minimum: 1
                            maximum: 65535
+                    loglevel:


Pretty sure this validation also needs to be changed, with the rename?

yes, that's true

agones-bot · 2019-08-23T09:36:46Z

Build Succeeded 👏

Build Id: 916af54a-7c22-486c-91e7-78312ceb0c55

The following development artifacts have been built, and will exist for the next 30 days:

image: gcr.io/agones-images/agones-controller:1.0.0-8c570b0
image: gcr.io/agones-images/agones-sdk:1.0.0-8c570b0
image: gcr.io/agones-images/agones-ping:1.0.0-8c570b0
Linux C++ SDK (build): agonessdk-1.0.0-8c570b0-linux-arch_64.tar.gz
SDK Server: agonessdk-server-1.0.0-8c570b0.zip

A preview of the website (the last 30 builds are retained):

https://8c570b0-dot-preview-dot-agones-images.appspot.com/

To install this version:

git fetch https://github.com/GoogleCloudPlatform/agones.git pull/1007/head:pr_1007 && git checkout pr_1007
helm install install/helm/agones --namespace agones-system --name agones --set agones.image.tag=1.0.0-8c570b0

roberthbailey · 2019-08-23T17:35:10Z

install/helm/agones/templates/crds/_gameserverspecvalidation.yaml

@@ -92,6 +92,17 @@ properties:
              type: integer
              minimum: 1
              maximum: 65535
+      sdk-server-loglevel:
+        type: string
+        enum:


I don't think we should expose so many log levels. This seems to be externalizing the fact that we are using logrus and would make it nearly impossible to change our logging library in the future. I feel like there are really three categories that people want:

Default (what we have today, which in basically the info level)

Errors and above

Debugging - everything

What if we abstracted the log levels from logrus and just offered something smaller like those three? Alternatively, we could give people a way to specifically disable the ping logs since those are the ones that cause the most noise in the log file.

Yes, less level would be more concise. I will do the change cause that would actually give more space for the changes in the future.

agones-bot · 2019-08-27T15:58:01Z

Build Succeeded 👏

Build Id: b0632155-c2e8-47fb-86e2-f91d56737d23

The following development artifacts have been built, and will exist for the next 30 days:

image: gcr.io/agones-images/agones-controller:1.0.0-f5247f7
image: gcr.io/agones-images/agones-sdk:1.0.0-f5247f7
image: gcr.io/agones-images/agones-ping:1.0.0-f5247f7
Linux C++ SDK (build): agonessdk-1.0.0-f5247f7-linux-arch_64.tar.gz
SDK Server: agonessdk-server-1.0.0-f5247f7.zip

A preview of the website (the last 30 builds are retained):

https://f5247f7-dot-preview-dot-agones-images.appspot.com/

To install this version:

git fetch https://github.com/GoogleCloudPlatform/agones.git pull/1007/head:pr_1007 && git checkout pr_1007
helm install install/helm/agones --namespace agones-system --name agones --set agones.image.tag=1.0.0-f5247f7

agones-bot · 2019-08-27T16:00:53Z

Build Succeeded 👏

Build Id: 7a085cc1-0600-4f5b-ba38-802783b8a935

The following development artifacts have been built, and will exist for the next 30 days:

image: gcr.io/agones-images/agones-controller:1.0.0-1d3ef31
image: gcr.io/agones-images/agones-sdk:1.0.0-1d3ef31
image: gcr.io/agones-images/agones-ping:1.0.0-1d3ef31
Linux C++ SDK (build): agonessdk-1.0.0-1d3ef31-linux-arch_64.tar.gz
SDK Server: agonessdk-server-1.0.0-1d3ef31.zip

A preview of the website (the last 30 builds are retained):

https://1d3ef31-dot-preview-dot-agones-images.appspot.com/

To install this version:

git fetch https://github.com/GoogleCloudPlatform/agones.git pull/1007/head:pr_1007 && git checkout pr_1007
helm install install/helm/agones --namespace agones-system --name agones --set agones.image.tag=1.0.0-1d3ef31

agones-bot · 2019-08-27T16:18:00Z

Build Succeeded 👏

Build Id: d0d73236-6774-4ffd-b06f-22b26ae6feaf

The following development artifacts have been built, and will exist for the next 30 days:

image: gcr.io/agones-images/agones-controller:1.0.0-458876a
image: gcr.io/agones-images/agones-sdk:1.0.0-458876a
image: gcr.io/agones-images/agones-ping:1.0.0-458876a
Linux C++ SDK (build): agonessdk-1.0.0-458876a-linux-arch_64.tar.gz
SDK Server: agonessdk-server-1.0.0-458876a.zip

A preview of the website (the last 30 builds are retained):

https://458876a-dot-preview-dot-agones-images.appspot.com/

To install this version:

git fetch https://github.com/GoogleCloudPlatform/agones.git pull/1007/head:pr_1007 && git checkout pr_1007
helm install install/helm/agones --namespace agones-system --name agones --set agones.image.tag=1.0.0-458876a

markmandel

This looks good to me. Since this adds a configuration option to GameServer which we can't break once its out there, @roberthbailey you good to give me an also +1 that's we're both happy with this PR ?

aLekSer · 2019-08-28T09:05:12Z

/assign @aLekSer

agones-bot · 2019-08-28T09:16:44Z

Build Succeeded 👏

Build Id: 3678dba6-96b2-4238-b041-81027322a405

The following development artifacts have been built, and will exist for the next 30 days:

image: gcr.io/agones-images/agones-controller:1.0.0-1c126f7
image: gcr.io/agones-images/agones-sdk:1.0.0-1c126f7
image: gcr.io/agones-images/agones-ping:1.0.0-1c126f7
Linux C++ SDK (build): agonessdk-1.0.0-1c126f7-linux-arch_64.tar.gz
SDK Server: agonessdk-server-1.0.0-1c126f7.zip

A preview of the website (the last 30 builds are retained):

https://1c126f7-dot-preview-dot-agones-images.appspot.com/

To install this version:

git fetch https://github.com/GoogleCloudPlatform/agones.git pull/1007/head:pr_1007 && git checkout pr_1007
helm install install/helm/agones --namespace agones-system --name agones --set agones.image.tag=1.0.0-1c126f7

agones-bot · 2019-09-03T17:34:25Z

Build Failed 😱

Build Id: d87c24ed-d156-49ec-a95a-e7bb9e576411

To get permission to view the Cloud Build view, join the agones-discuss Google Group.

aLekSer · 2019-09-10T13:58:05Z

I have merged master to the branch.

agones-bot · 2019-09-10T14:16:05Z

Build Succeeded 👏

Build Id: 7f74c6d7-1178-4b09-9fc4-0bbfdd359d26

The following development artifacts have been built, and will exist for the next 30 days:

image: gcr.io/agones-images/agones-controller:1.0.0-d55e6ae
image: gcr.io/agones-images/agones-sdk:1.0.0-d55e6ae
image: gcr.io/agones-images/agones-ping:1.0.0-d55e6ae
Linux C++ SDK (build): agonessdk-1.0.0-d55e6ae-linux-arch_64.tar.gz
SDK Server: agonessdk-server-1.0.0-d55e6ae.zip

A preview of the website (the last 30 builds are retained):

https://d55e6ae-dot-preview-dot-agones-images.appspot.com/

To install this version:

git fetch https://github.com/GoogleCloudPlatform/agones.git pull/1007/head:pr_1007 && git checkout pr_1007
helm install install/helm/agones --namespace agones-system --name agones --set agones.image.tag=1.0.0-d55e6ae

aLekSer · 2019-09-18T11:31:38Z

Updated publishVersion to a new one:
{{% feature publishVersion="1.1.0" %}}

Also I have found an issue with make gen-api-docs that if PR moves through the release, then it doesn't see new changes and doesn't update versions accordingly.
So it was needed to perform an extra step before the command:
git checkout master ../site/content/en/docs/Reference/agones_crd_api_reference.html

PR is now ready for review (and merge).

aLekSer · 2019-09-19T14:00:39Z

Build failed for some strange reason - no status comment was generated here on github PR:

Status	
 Build failed
Status detail	
failed unmarshalling build config cloudbuild.yaml: proto: google.devtools.cloudbuild.v1.Build.timeout|"timeout": google.protobuf.Duration: invalid duration value "1h"
Build id	
0867e0f5-6a9b-48b8-92bb-f9abb0d96c16
Image	
—
Trigger	
Push to github_pr_1007 branch (agones)

agones-bot · 2019-09-19T14:16:10Z

Build Succeeded 👏

Build Id: 619e3d42-f1ba-4483-88e5-ed3d1f426774

The following development artifacts have been built, and will exist for the next 30 days:

image: gcr.io/agones-images/agones-controller:1.1.0-ffd2890
image: gcr.io/agones-images/agones-sdk:1.1.0-ffd2890
image: gcr.io/agones-images/agones-ping:1.1.0-ffd2890
Linux C++ SDK (build): agonessdk-1.1.0-ffd2890-linux-arch_64.tar.gz
SDK Server: agonessdk-server-1.1.0-ffd2890.zip

A preview of the website (the last 30 builds are retained):

https://ffd2890-dot-preview-dot-agones-images.appspot.com/

To install this version:

git fetch https://github.com/GoogleCloudPlatform/agones.git pull/1007/head:pr_1007 && git checkout pr_1007
helm install install/helm/agones --namespace agones-system --name agones --set agones.image.tag=1.1.0-ffd2890

roberthbailey

I did another pass and had a few more comments for you.

pkg/apis/agones/v1/gameserver.go

roberthbailey · 2019-09-19T18:06:24Z

pkg/apis/agones/v1/gameserver.go

 	// Template describes the Pod that will be created for the GameServer
 	Template corev1.PodTemplateSpec `json:"template"`
 }

+// Logging contains log levels for Agones system containers
+type Logging struct {
+	// SdkServer is a log level for SDK server (sidecar) logs


Please add Defaults to "Info" at the end of this comment.

pkg/apis/agones/v1/gameserver_test.go

roberthbailey · 2019-09-19T18:08:40Z

pkg/apis/agones/v1/gameserver_test.go

@@ -205,17 +212,19 @@ func TestGameServerApplyDefaults(t *testing.T) {
 							Protocol:      corev1.ProtocolTCP,
 						},
 					},
-					Health: Health{Disabled: true},
+					Health:  Health{Disabled: true},
+					Logging: Logging{SdkServer: "Debug"},


rather than piggyback on an existing test case ("convert from legacy single port to multiple" to test applying a custom log level, please add a new test case that specifically tests setting the log level.

OK, adding a separate test

roberthbailey · 2019-09-19T18:09:13Z

site/content/en/docs/Reference/fleet.md

@@ -57,6 +57,11 @@ spec:
      health:
        initialDelaySeconds: 30
        periodSeconds: 60
+{{% feature publishVersion="1.0.0" %}}


This should now be 1.1.0

agones-bot · 2019-09-20T10:23:50Z

Build Failed 😱

Build Id: 838b17fc-c2cb-4970-a589-7685c6b8b927

To get permission to view the Cloud Build view, join the agones-discuss Google Group.

aLekSer · 2019-09-20T10:23:57Z

Applied comments and added agones_crd_api_reference.html

agones-bot · 2019-09-20T10:31:05Z

Build Failed 😱

Build Id: 41a79350-09d9-4c67-a281-2231e8cdeb9f

To get permission to view the Cloud Build view, join the agones-discuss Google Group.

agones-bot · 2019-09-20T10:56:02Z

Build Succeeded 👏

Build Id: 1dae75b1-a06d-4fe4-9539-cedca78bdd42

The following development artifacts have been built, and will exist for the next 30 days:

image: gcr.io/agones-images/agones-controller:1.1.0-3e4c972
image: gcr.io/agones-images/agones-sdk:1.1.0-3e4c972
image: gcr.io/agones-images/agones-ping:1.1.0-3e4c972
Linux C++ SDK (build): agonessdk-1.1.0-3e4c972-linux-arch_64.tar.gz
SDK Server: agonessdk-server-1.1.0-3e4c972.zip

A preview of the website (the last 30 builds are retained):

https://3e4c972-dot-preview-dot-agones-images.appspot.com/

To install this version:

git fetch https://github.com/GoogleCloudPlatform/agones.git pull/1007/head:pr_1007 && git checkout pr_1007
helm install install/helm/agones --namespace agones-system --name agones --set agones.image.tag=1.1.0-3e4c972

Add ability to specify logrus log level in yaml configuration and apply this log level on creating the GameServer.

agones-bot · 2019-09-20T13:01:01Z

Build Succeeded 👏

Build Id: e93355dd-0519-42b2-a1a6-cc9b3cd7c4a6

The following development artifacts have been built, and will exist for the next 30 days:

image: gcr.io/agones-images/agones-controller:1.1.0-51ea158
image: gcr.io/agones-images/agones-sdk:1.1.0-51ea158
image: gcr.io/agones-images/agones-ping:1.1.0-51ea158
Linux C++ SDK (build): agonessdk-1.1.0-51ea158-linux-arch_64.tar.gz
SDK Server: agonessdk-server-1.1.0-51ea158.zip

A preview of the website (the last 30 builds are retained):

https://51ea158-dot-preview-dot-agones-images.appspot.com/

To install this version:

git fetch https://github.com/GoogleCloudPlatform/agones.git pull/1007/head:pr_1007 && git checkout pr_1007
helm install install/helm/agones --namespace agones-system --name agones --set agones.image.tag=1.1.0-51ea158

agones-bot · 2019-09-20T13:03:08Z

Build Succeeded 👏

Build Id: f0e5420e-e806-4bb7-be59-98c10c281c98

The following development artifacts have been built, and will exist for the next 30 days:

image: gcr.io/agones-images/agones-controller:1.1.0-3b2365a
image: gcr.io/agones-images/agones-sdk:1.1.0-3b2365a
image: gcr.io/agones-images/agones-ping:1.1.0-3b2365a
Linux C++ SDK (build): agonessdk-1.1.0-3b2365a-linux-arch_64.tar.gz
SDK Server: agonessdk-server-1.1.0-3b2365a.zip

A preview of the website (the last 30 builds are retained):

https://3b2365a-dot-preview-dot-agones-images.appspot.com/

To install this version:

git fetch https://github.com/GoogleCloudPlatform/agones.git pull/1007/head:pr_1007 && git checkout pr_1007
helm install install/helm/agones --namespace agones-system --name agones --set agones.image.tag=1.1.0-3b2365a

google-oss-robot · 2019-09-20T16:15:29Z

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: aLekSer, roberthbailey
To complete the pull request process, please assign
You can assign the PR to them by writing /assign in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

aLekSer force-pushed the feature/gs-log-level branch from a2301e2 to 0402062 Compare August 21, 2019 16:19

aLekSer changed the title ~~Add Sidecar log level through GS specification~~ Add Sidecar log level parameter to GS specification Aug 21, 2019

markmandel reviewed Aug 21, 2019

View reviewed changes

aLekSer force-pushed the feature/gs-log-level branch 2 times, most recently from f96fe14 to d9987ac Compare August 22, 2019 17:32

aLekSer marked this pull request as ready for review August 22, 2019 18:34

markmandel reviewed Aug 22, 2019

View reviewed changes

aLekSer force-pushed the feature/gs-log-level branch from d9987ac to 8c570b0 Compare August 23, 2019 09:22

roberthbailey reviewed Aug 23, 2019

View reviewed changes

aLekSer force-pushed the feature/gs-log-level branch 2 times, most recently from f5247f7 to 1d3ef31 Compare August 27, 2019 15:45

aLekSer force-pushed the feature/gs-log-level branch from 1d3ef31 to 458876a Compare August 27, 2019 16:03

markmandel reviewed Aug 27, 2019

View reviewed changes

aLekSer force-pushed the feature/gs-log-level branch from 458876a to 1c126f7 Compare August 28, 2019 09:01

google-oss-robot added the size/XXL label Aug 28, 2019

google-oss-robot assigned aLekSer Aug 28, 2019

markmandel added the feature-freeze-do-not-merge Only eligible to be merged once we are out of feature freeze (next full release) label Sep 10, 2019

markmandel removed the feature-freeze-do-not-merge Only eligible to be merged once we are out of feature freeze (next full release) label Sep 17, 2019

aLekSer force-pushed the feature/gs-log-level branch from d55e6ae to c4ee99c Compare September 18, 2019 11:28

aLekSer force-pushed the feature/gs-log-level branch from c4ee99c to ffd2890 Compare September 19, 2019 13:57

roberthbailey reviewed Sep 19, 2019

View reviewed changes

aLekSer force-pushed the feature/gs-log-level branch 2 times, most recently from a4156b8 to b0b913e Compare September 20, 2019 10:23

aLekSer force-pushed the feature/gs-log-level branch from b0b913e to 3e4c972 Compare September 20, 2019 10:36

aLekSer force-pushed the feature/gs-log-level branch from 3e4c972 to 51ea158 Compare September 20, 2019 12:41

Add Sidecar log level through GS specification

3b2365a

Add ability to specify logrus log level in yaml configuration and apply this log level on creating the GameServer.

aLekSer force-pushed the feature/gs-log-level branch from 51ea158 to 3b2365a Compare September 20, 2019 12:42

roberthbailey approved these changes Sep 20, 2019

View reviewed changes

google-oss-robot added the lgtm label Sep 20, 2019

roberthbailey merged commit fc9169c into googleforgames:master Sep 20, 2019

roberthbailey added this to the 1.1.0 milestone Sep 20, 2019

roberthbailey mentioned this pull request Sep 27, 2019

Sdkserver port configuration #1078

Merged

markmandel added area/operations Installation, updating, metrics etc kind/feature New features for Agones labels Oct 22, 2019

Add Sidecar log level parameter to GS specification #1007

Add Sidecar log level parameter to GS specification #1007

Conversation

aLekSer commented Aug 21, 2019

aLekSer commented Aug 21, 2019

agones-bot commented Aug 21, 2019

aLekSer commented Aug 21, 2019

agones-bot commented Aug 21, 2019

Choose a reason for hiding this comment

Choose a reason for hiding this comment

agones-bot commented Aug 22, 2019

agones-bot commented Aug 22, 2019

aLekSer commented Aug 22, 2019

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

agones-bot commented Aug 23, 2019

Choose a reason for hiding this comment

Choose a reason for hiding this comment

agones-bot commented Aug 27, 2019

agones-bot commented Aug 27, 2019

agones-bot commented Aug 27, 2019

markmandel left a comment

Choose a reason for hiding this comment

aLekSer commented Aug 28, 2019

agones-bot commented Aug 28, 2019

agones-bot commented Sep 3, 2019

aLekSer commented Sep 10, 2019

agones-bot commented Sep 10, 2019

aLekSer commented Sep 18, 2019 • edited

aLekSer commented Sep 19, 2019

agones-bot commented Sep 19, 2019

roberthbailey left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

agones-bot commented Sep 20, 2019

aLekSer commented Sep 20, 2019

agones-bot commented Sep 20, 2019

agones-bot commented Sep 20, 2019

agones-bot commented Sep 20, 2019

agones-bot commented Sep 20, 2019

google-oss-robot commented Sep 20, 2019

aLekSer commented Sep 18, 2019 •

edited