Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

2 Hotfixes: Allow Helm to reference image digests and inject licenses #631

Merged
merged 2 commits into from Mar 1, 2019

Conversation

@bbf
Copy link
Contributor

commented Mar 1, 2019

This PR allows Helm to reference image digests by allowing the injection of them for each image and also automates the extraction and copying of all licences into the images under /home/agones/LICENSES.

I'm going to monitor the bot for any test failures. I also left no trailing spaces in any of the files I touched! die spaces, die!

Allow Helm overrides for digest hashes in each of the images used by …
…Agones.

This doesn't change the default behavior that is currently documented, and willl only probably be used by automated systems that want to enforce strictness when using specific images.
@agones-bot

This comment has been minimized.

Copy link
Collaborator

commented Mar 1, 2019

Build Failed 😱

Build Id: 17e1345d-eac5-4330-960b-77fbf9de8e73

To get permission to view the Cloud Build view, join the agones-discuss Google Group.

@markmandel

This comment has been minimized.

Copy link
Collaborator

commented Mar 1, 2019

Fixed the first issue - here is a patch.
patch.txt

Now failing (locally) with

Step 3/6 : COPY --chown=agones:root ./bin/sdk-server.linux.amd64 /home/agones/sdk-server
 ---> b1b7a39ab966
Step 4/6 : COPY --chown=agones:root ./bin/LICENSES /home/agones/LICENSES
COPY failed: stat /usr/local/google/docker/tmp/docker-builder674808864/bin/LICENSES: no such file or directory
Makefile:314: recipe for target 'build-agones-sdk-image' failed
make: *** [build-agones-sdk-image] Error 1

@bbf bbf force-pushed the bbf:hotfix-0.8.1_bbf branch from 843f338 to bfa806c Mar 1, 2019

@agones-bot

This comment has been minimized.

Copy link
Collaborator

commented Mar 1, 2019

Build Succeeded 👏

Build Id: 11611f74-8f08-4e6c-8835-1e64359190fc

The following development artifacts have been built, and will exist for the next 30 days:

A preview of the website (the last 30 builds are retained):

To install this version:

  • git fetch https://github.com/GoogleCloudPlatform/agones.git pull/631/head:pr_631 && git checkout pr_631
  • helm install install/helm/agones --namespace agones-system --name agones --set agones.image.tag=0.8.1-bfa806c
@bbf

This comment has been minimized.

Copy link
Contributor Author

commented Mar 1, 2019

Removing the "-it" from Docker run and fixing the brain fart of not referencing the sdk-server have fixed the issues \o/

@markmandel
Copy link
Collaborator

left a comment

🔥

@markmandel markmandel merged commit bca3165 into googleforgames:hotfix-0.8.1 Mar 1, 2019

2 checks passed

agones-bot Build 11611f74-8f08-4e6c-8835-1e64359190fc succeeded
Details
cla/google All necessary CLAs are signed

@markmandel markmandel added this to the 0.8.1 milestone Mar 1, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.