Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add instructions about taints and tolerations to the install instructions #870

Merged

Conversation

@roberthbailey
Copy link
Member

commented Jul 3, 2019

And a specific example for GKE. Remove some of the duplicate verbiage from the Helm instructions.

Ref: #491

@roberthbailey

This comment has been minimized.

Copy link
Member Author

commented Jul 3, 2019

/cc @markmandel

I'm not sure how to verify if I made the relative link correctly locally.

@markmandel

This comment has been minimized.

Copy link
Collaborator

commented Jul 3, 2019

Looks like updates need to be made to for the website: https://github.com/googleforgames/agones/blob/master/build/README.md

make site-server will start the local server, so you can see what is happening.

If you want to run the site tests make site-test to run them locally.

@markmandel

This comment has been minimized.

Copy link
Collaborator

commented Jul 3, 2019

We also have some docs instructions here: https://agones.dev/site/docs/contribute/

Which is actually a better spot to be updated.

@agones-bot

This comment has been minimized.

Copy link
Collaborator

commented Jul 3, 2019

Build Succeeded 👏

Build Id: de4f1ec7-817d-44b9-af69-de5f63040342

The following development artifacts have been built, and will exist for the next 30 days:

A preview of the website (the last 30 builds are retained):

To install this version:

  • git fetch https://github.com/GoogleCloudPlatform/agones.git pull/870/head:pr_870 && git checkout pr_870
  • helm install install/helm/agones --namespace agones-system --name agones --set agones.image.tag=0.12.0-bb505a1
Add instructions about taints and tolerations to the install instruct…
…ions,

with a specific example for GKE. Remove some of the duplicate verbiage
from the Helm instructions.

@roberthbailey roberthbailey force-pushed the roberthbailey:taints-and-tolerations branch from bb505a1 to 79b1b53 Jul 3, 2019

@markmandel
Copy link
Collaborator

left a comment

🏇

@roberthbailey

This comment has been minimized.

Copy link
Member Author

commented Jul 3, 2019

$ make site-test
xcrun: error: invalid active developer path (/Library/Developer/CommandLineTools), missing xcrun at: /Library/Developer/CommandLineTools/usr/bin/xcrun

@roberthbailey

This comment has been minimized.

Copy link
Member Author

commented Jul 3, 2019

Seems like I need to look into that a bit more....

@agones-bot

This comment has been minimized.

Copy link
Collaborator

commented Jul 3, 2019

Build Succeeded 👏

Build Id: c1a2718e-74ae-4584-bd71-2def8c031cbe

The following development artifacts have been built, and will exist for the next 30 days:

A preview of the website (the last 30 builds are retained):

To install this version:

  • git fetch https://github.com/GoogleCloudPlatform/agones.git pull/870/head:pr_870 && git checkout pr_870
  • helm install install/helm/agones --namespace agones-system --name agones --set agones.image.tag=0.12.0-79b1b53

@markmandel markmandel merged commit e621065 into googleforgames:master Jul 3, 2019

2 checks passed

agones-bot Build c1a2718e-74ae-4584-bd71-2def8c031cbe succeeded
Details
cla/google All necessary CLAs are signed
@roberthbailey

This comment has been minimized.

Copy link
Member Author

commented Jul 3, 2019

Looks like I somehow borked my xcode install, which I'm in the process of fixing. It should be easier to verify the next one.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.