Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Promote allocation to v1 #881

Merged
merged 10 commits into from Jul 10, 2019

Conversation

@roberthbailey
Copy link
Member

commented Jul 9, 2019

This is part of #703.

/assign @markmandel
/label kind/breaking

@agones-bot

This comment has been minimized.

Copy link
Collaborator

commented Jul 9, 2019

Build Failed 😱

Build Id: aaea0182-0dca-479d-943d-4f6f88dfb5aa

To get permission to view the Cloud Build view, join the agones-discuss Google Group.

@markmandel

This comment has been minimized.

Copy link
Collaborator

commented Jul 9, 2019

Looks like you need a make gen-install 😄

@roberthbailey

This comment has been minimized.

Copy link
Member Author

commented Jul 9, 2019

Yes.... sometimes it's hard to tell which files are edited and which are generated.

@roberthbailey

This comment has been minimized.

Copy link
Member Author

commented Jul 9, 2019

This is likely to need another helm reset too.

@agones-bot

This comment has been minimized.

Copy link
Collaborator

commented Jul 9, 2019

Build Failed 😱

Build Id: 3e8b2c75-701c-4b94-964a-6e9099918e6d

To get permission to view the Cloud Build view, join the agones-discuss Google Group.

@roberthbailey

This comment has been minimized.

Copy link
Member Author

commented Jul 9, 2019

The last cloud build failed on helm like the previous PR.

@roberthbailey roberthbailey force-pushed the roberthbailey:allocation-to-v1 branch from 63931ae to 553868b Jul 9, 2019

@agones-bot

This comment has been minimized.

Copy link
Collaborator

commented Jul 9, 2019

Build Failed 😱

Build Id: a8277404-4972-4d03-841d-9f79ada6a29f

To get permission to view the Cloud Build view, join the agones-discuss Google Group.

@markmandel
Copy link
Collaborator

left a comment

A few small things, but overall look good 👍

@@ -236,11 +236,11 @@ $ curl http://localhost:8001/apis/stable.agones.dev/v1alpha1/namespaces/default/
# allocate a gameserver from a fleet named 'simple-udp', with GameServerAllocation
$ curl -d '{"apiVersion":"allocation.agones.dev/v1alpha1","kind":"GameServerAllocation","spec":{"required":{"matchLabels":{"stable.agones.dev/fleet":"simple-udp"}}}}' -H "Content-Type: application/json" -X POST http://localhost:8001/apis/allocation.agones.dev/v1alpha1/namespaces/default/gameserverallocations
$ curl -d '{"apiVersion":"allocation.agones.dev/v1","kind":"GameServerAllocation","spec":{"required":{"matchLabels":{"stable.agones.dev/fleet":"simple-udp"}}}}' -H "Content-Type: application/json" -X POST http://localhost:8001/apis/allocation.agones.dev/v1/namespaces/default/gameserverallocations

This comment has been minimized.

Copy link
@markmandel

markmandel Jul 9, 2019

Collaborator

we'll need to {{< feature >}} this

This comment has been minimized.

Copy link
@roberthbailey

roberthbailey Jul 9, 2019

Author Member

Good catch. Fixed.

@markmandel

This comment has been minimized.

Copy link
Collaborator

commented Jul 9, 2019

Deleting the helm install, and rerunning!

@roberthbailey roberthbailey force-pushed the roberthbailey:allocation-to-v1 branch 3 times, most recently from 63245de to a2fc27d Jul 9, 2019

@agones-bot

This comment has been minimized.

Copy link
Collaborator

commented Jul 9, 2019

Build Failed 😱

Build Id: 8e31cb19-5d58-4d31-b31c-15af45e72be7

To get permission to view the Cloud Build view, join the agones-discuss Google Group.

@agones-bot

This comment has been minimized.

Copy link
Collaborator

commented Jul 9, 2019

Build Failed 😱

Build Id: bcdaa85b-5d38-415e-a9ca-936cba3585df

To get permission to view the Cloud Build view, join the agones-discuss Google Group.

@agones-bot

This comment has been minimized.

Copy link
Collaborator

commented Jul 9, 2019

Build Failed 😱

Build Id: c8c773ad-7ac8-4bce-b644-047b1d743dea

To get permission to view the Cloud Build view, join the agones-discuss Google Group.

@roberthbailey roberthbailey force-pushed the roberthbailey:allocation-to-v1 branch from a2fc27d to baf054c Jul 9, 2019

@agones-bot

This comment has been minimized.

Copy link
Collaborator

commented Jul 10, 2019

Build Succeeded 👏

Build Id: 116af778-52a6-4056-8d10-61f13a33fd1c

The following development artifacts have been built, and will exist for the next 30 days:

A preview of the website (the last 30 builds are retained):

To install this version:

  • git fetch https://github.com/GoogleCloudPlatform/agones.git pull/881/head:pr_881 && git checkout pr_881
  • helm install install/helm/agones --namespace agones-system --name agones --set agones.image.tag=0.12.0-baf054c

@roberthbailey roberthbailey force-pushed the roberthbailey:allocation-to-v1 branch from baf054c to 4b6f3f9 Jul 10, 2019

@agones-bot

This comment has been minimized.

Copy link
Collaborator

commented Jul 10, 2019

Build Failed 😱

Build Id: eddad440-1c4b-4a1e-8b06-f28234e204b1

To get permission to view the Cloud Build view, join the agones-discuss Google Group.

@roberthbailey roberthbailey force-pushed the roberthbailey:allocation-to-v1 branch from 4b6f3f9 to 549d248 Jul 10, 2019

@roberthbailey

This comment has been minimized.

Copy link
Member Author

commented Jul 10, 2019

I'm seeing a weird error on the e2e tests:

Already have image: e2e-runner
cp: cannot stat '/workspace/./build/.gomod/cache/vcs/b9a4b9bbdb4a59723f2348415ad7ffda91568455a1cfd92e97976132bdfbaf57/shallow.lock': No such file or directory

This doesn't seem related to my change and I'm not sure how to fix it.

@markmandel

This comment has been minimized.

Copy link
Collaborator

commented Jul 10, 2019

I think Cloud Build is having a sad. Will retry shortly.

@agones-bot

This comment has been minimized.

Copy link
Collaborator

commented Jul 10, 2019

Build Failed 😱

Build Id: 5326b151-4ec2-4765-9433-50cd23482c7d

To get permission to view the Cloud Build view, join the agones-discuss Google Group.

@agones-bot

This comment has been minimized.

Copy link
Collaborator

commented Jul 10, 2019

Build Failed 😱

Build Id: 65672089-5f34-41f6-9dc6-0b7cf6dfb421

To get permission to view the Cloud Build view, join the agones-discuss Google Group.

@markmandel

This comment has been minimized.

Copy link
Collaborator

commented Jul 10, 2019

Yep,, definite sad.

@agones-bot

This comment has been minimized.

Copy link
Collaborator

commented Jul 10, 2019

Build Failed 😱

Build Id: f3795921-3f1b-49c2-bbd7-bfdf93424a10

To get permission to view the Cloud Build view, join the agones-discuss Google Group.

@agones-bot

This comment has been minimized.

Copy link
Collaborator

commented Jul 10, 2019

Build Failed 😱

Build Id: 1367c36f-d8ce-4eda-9334-1ee448b3b402

To get permission to view the Cloud Build view, join the agones-discuss Google Group.

@agones-bot

This comment has been minimized.

Copy link
Collaborator

commented Jul 10, 2019

Build Succeeded 👏

Build Id: 6c7faa2b-94a9-403c-bace-b8eb9dc81af5

The following development artifacts have been built, and will exist for the next 30 days:

A preview of the website (the last 30 builds are retained):

To install this version:

  • git fetch https://github.com/GoogleCloudPlatform/agones.git pull/881/head:pr_881 && git checkout pr_881
  • helm install install/helm/agones --namespace agones-system --name agones --set agones.image.tag=0.12.0-549d248
@roberthbailey

This comment has been minimized.

Copy link
Member Author

commented Jul 10, 2019

I was having trouble reproducing this failure locally:

$ make test-e2e
...
ok  	agones.dev/agones/test/e2e	551.763s
echo "Finishing e2e test runner!"
Finishing e2e test runner!

and for some reason after a few re-tries cloud build is now working too.

@markmandel
Copy link
Collaborator

left a comment

👍 awesome.

markmandel added 2 commits Jul 10, 2019
@agones-bot

This comment has been minimized.

Copy link
Collaborator

commented Jul 10, 2019

Build Succeeded 👏

Build Id: 8b666f00-09ad-4e38-a3be-6037cdbc3560

The following development artifacts have been built, and will exist for the next 30 days:

A preview of the website (the last 30 builds are retained):

To install this version:

  • git fetch https://github.com/GoogleCloudPlatform/agones.git pull/881/head:pr_881 && git checkout pr_881
  • helm install install/helm/agones --namespace agones-system --name agones --set agones.image.tag=0.12.0-ff3203e

@markmandel markmandel merged commit 194293e into googleforgames:master Jul 10, 2019

2 checks passed

agones-bot Build 8b666f00-09ad-4e38-a3be-6037cdbc3560 succeeded
Details
cla/google All necessary CLAs are signed

@markmandel markmandel added this to the 0.12.0 milestone Jul 10, 2019

@roberthbailey roberthbailey referenced this pull request Jul 16, 2019
5 of 5 tasks complete

@roberthbailey roberthbailey deleted the roberthbailey:allocation-to-v1 branch Aug 1, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.