Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Compliance tests for Reserve(seconds). #920

Merged

Conversation

@markmandel
Copy link
Collaborator

commented Jul 17, 2019

Currently only running in the golang test, as that's the only one that implements SDK.Reserve(seconds).

Added a couple of cleanup items in the conformance test makefile as well.

Work on #660

@markmandel

This comment has been minimized.

Copy link
Collaborator Author

commented Jul 17, 2019

@aLekSer you happy with these changes?

@agones-bot

This comment has been minimized.

Copy link
Collaborator

commented Jul 18, 2019

Build Succeeded 👏

Build Id: aa66807e-c4f3-4028-ad43-dd583c9cba1e

The following development artifacts have been built, and will exist for the next 30 days:

A preview of the website (the last 30 builds are retained):

To install this version:

  • git fetch https://github.com/GoogleCloudPlatform/agones.git pull/920/head:pr_920 && git checkout pr_920
  • helm install install/helm/agones --namespace agones-system --name agones --set agones.image.tag=0.12.0-59a0cfd

@markmandel markmandel force-pushed the markmandel:feature/reserve-compliance branch from 59a0cfd to e63f0a6 Jul 18, 2019

@agones-bot

This comment has been minimized.

Copy link
Collaborator

commented Jul 19, 2019

Build Failed 😱

Build Id: a63f4292-8541-48c8-9d49-2784a5b6fd30

To get permission to view the Cloud Build view, join the agones-discuss Google Group.

@markmandel markmandel force-pushed the markmandel:feature/reserve-compliance branch from e63f0a6 to 28d4a15 Jul 19, 2019

@agones-bot

This comment has been minimized.

Copy link
Collaborator

commented Jul 19, 2019

Build Succeeded 👏

Build Id: 0bfb04ac-3260-4fa3-a33f-60d196c44946

The following development artifacts have been built, and will exist for the next 30 days:

A preview of the website (the last 30 builds are retained):

To install this version:

  • git fetch https://github.com/GoogleCloudPlatform/agones.git pull/920/head:pr_920 && git checkout pr_920
  • helm install install/helm/agones --namespace agones-system --name agones --set agones.image.tag=0.12.0-28d4a15
@@ -0,0 +1 @@
../../../../sdks/nodejs

This comment has been minimized.

Copy link
@roberthbailey

roberthbailey Jul 19, 2019

Member

Should this file (and the next one) but added? They appear when I run tests but I'm not sure whether they should be checked in.

This comment has been minimized.

Copy link
@markmandel

markmandel Jul 19, 2019

Author Collaborator

oops! probably not. Let me go back and remove them.

Should I .gitignore them now, since I'm in there?

This comment has been minimized.

Copy link
@roberthbailey

roberthbailey Jul 19, 2019

Member

That sounds like a good idea.

@agones-bot

This comment has been minimized.

Copy link
Collaborator

commented Jul 19, 2019

Build Succeeded 👏

Build Id: 7511bf54-880b-42bf-882f-86741f78b1be

The following development artifacts have been built, and will exist for the next 30 days:

A preview of the website (the last 30 builds are retained):

To install this version:

  • git fetch https://github.com/GoogleCloudPlatform/agones.git pull/920/head:pr_920 && git checkout pr_920
  • helm install install/helm/agones --namespace agones-system --name agones --set agones.image.tag=0.12.0-0fbabca
Compliance tests for Reserve(seconds).
Currently only running in the golang test, as that's the only
one that impements it.

@markmandel markmandel force-pushed the markmandel:feature/reserve-compliance branch from 0fbabca to 8833914 Jul 19, 2019

@agones-bot

This comment has been minimized.

Copy link
Collaborator

commented Jul 19, 2019

Build Succeeded 👏

Build Id: c3386e98-cf96-46f7-8312-b21baa90ad65

The following development artifacts have been built, and will exist for the next 30 days:

A preview of the website (the last 30 builds are retained):

To install this version:

  • git fetch https://github.com/GoogleCloudPlatform/agones.git pull/920/head:pr_920 && git checkout pr_920
  • helm install install/helm/agones --namespace agones-system --name agones --set agones.image.tag=0.12.0-8833914
@agones-bot

This comment has been minimized.

Copy link
Collaborator

commented Jul 20, 2019

Build Succeeded 👏

Build Id: 822df0b6-0d1d-4fc4-81c8-19ba750fab57

The following development artifacts have been built, and will exist for the next 30 days:

A preview of the website (the last 30 builds are retained):

To install this version:

  • git fetch https://github.com/GoogleCloudPlatform/agones.git pull/920/head:pr_920 && git checkout pr_920
  • helm install install/helm/agones --namespace agones-system --name agones --set agones.image.tag=0.12.0-19f6a99

@roberthbailey roberthbailey merged commit f3e050d into googleforgames:master Jul 20, 2019

2 checks passed

agones-bot Build 822df0b6-0d1d-4fc4-81c8-19ba750fab57 succeeded
Details
cla/google All necessary CLAs are signed

@markmandel markmandel deleted the markmandel:feature/reserve-compliance branch Jul 20, 2019

@markmandel markmandel added this to the 0.12.0 milestone Jul 20, 2019

@aLekSer

This comment has been minimized.

Copy link
Contributor

commented Jul 22, 2019

Thanks for improving make targets.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants
You can’t perform that action at this time.