Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

C++ SDK: Update the function signature of WatchGameServer to use a const-reference #951

Merged

Conversation

@roberthbailey
Copy link
Member

commented Jul 26, 2019

Also update the simple cpp example so that it still compiles.

Fixes #941.

@roberthbailey roberthbailey force-pushed the roberthbailey:cpp-watch-gameserver branch from 180791f to 0764004 Jul 26, 2019

@agones-bot

This comment has been minimized.

Copy link
Collaborator

commented Jul 26, 2019

Build Succeeded 👏

Build Id: 7aba4b6c-f97a-4dc1-af78-43ea17eb9997

The following development artifacts have been built, and will exist for the next 30 days:

A preview of the website (the last 30 builds are retained):

To install this version:

  • git fetch https://github.com/GoogleCloudPlatform/agones.git pull/951/head:pr_951 && git checkout pr_951
  • helm install install/helm/agones --namespace agones-system --name agones --set agones.image.tag=0.12.0-180791f
@agones-bot

This comment has been minimized.

Copy link
Collaborator

commented Jul 26, 2019

Build Succeeded 👏

Build Id: 22eda562-774f-4fde-8d13-57757e172e84

The following development artifacts have been built, and will exist for the next 30 days:

A preview of the website (the last 30 builds are retained):

To install this version:

  • git fetch https://github.com/GoogleCloudPlatform/agones.git pull/951/head:pr_951 && git checkout pr_951
  • helm install install/helm/agones --namespace agones-system --name agones --set agones.image.tag=0.12.0-0764004

@roberthbailey roberthbailey force-pushed the roberthbailey:cpp-watch-gameserver branch from 0764004 to c8f6be2 Jul 26, 2019

@agones-bot

This comment has been minimized.

Copy link
Collaborator

commented Jul 26, 2019

Build Succeeded 👏

Build Id: e54af7dd-8117-4955-9a7c-a4473015e7a8

The following development artifacts have been built, and will exist for the next 30 days:

A preview of the website (the last 30 builds are retained):

To install this version:

  • git fetch https://github.com/GoogleCloudPlatform/agones.git pull/951/head:pr_951 && git checkout pr_951
  • helm install install/helm/agones --namespace agones-system --name agones --set agones.image.tag=0.12.0-c8f6be2

@roberthbailey roberthbailey added this to the 0.12.0 milestone Jul 26, 2019

@markmandel

This comment has been minimized.

Copy link
Collaborator

commented Jul 27, 2019

@devjgm - I'm assuming this is correct? If so, I'm happy to commit and push through 👍

@devjgm
devjgm approved these changes Jul 27, 2019

@roberthbailey roberthbailey force-pushed the roberthbailey:cpp-watch-gameserver branch from c8f6be2 to bc80f38 Jul 27, 2019

@agones-bot

This comment has been minimized.

Copy link
Collaborator

commented Jul 27, 2019

Build Succeeded 👏

Build Id: f87692cb-20f9-4683-afbc-3e65f21346cd

The following development artifacts have been built, and will exist for the next 30 days:

A preview of the website (the last 30 builds are retained):

To install this version:

  • git fetch https://github.com/GoogleCloudPlatform/agones.git pull/951/head:pr_951 && git checkout pr_951
  • helm install install/helm/agones --namespace agones-system --name agones --set agones.image.tag=0.12.0-bc80f38
@markmandel
Copy link
Collaborator

left a comment

🍰

C++ SDK: Update the function signature of WatchGameServer to use a
const-reference. Also update the simple cpp example so that it still
compiles.

@roberthbailey roberthbailey force-pushed the roberthbailey:cpp-watch-gameserver branch from efc4752 to e4812f0 Jul 27, 2019

@agones-bot

This comment has been minimized.

Copy link
Collaborator

commented Jul 27, 2019

Build Succeeded 👏

Build Id: 2c90eca6-6aef-40d3-b27a-f96ba470e814

The following development artifacts have been built, and will exist for the next 30 days:

A preview of the website (the last 30 builds are retained):

To install this version:

  • git fetch https://github.com/GoogleCloudPlatform/agones.git pull/951/head:pr_951 && git checkout pr_951
  • helm install install/helm/agones --namespace agones-system --name agones --set agones.image.tag=0.12.0-efc4752
@agones-bot

This comment has been minimized.

Copy link
Collaborator

commented Jul 27, 2019

Build Succeeded 👏

Build Id: ac4437d9-63ec-4188-8147-06accc6e9f44

The following development artifacts have been built, and will exist for the next 30 days:

A preview of the website (the last 30 builds are retained):

To install this version:

  • git fetch https://github.com/GoogleCloudPlatform/agones.git pull/951/head:pr_951 && git checkout pr_951
  • helm install install/helm/agones --namespace agones-system --name agones --set agones.image.tag=0.12.0-e4812f0

@markmandel markmandel merged commit 496aa2e into googleforgames:master Jul 27, 2019

2 checks passed

agones-bot Build ac4437d9-63ec-4188-8147-06accc6e9f44 succeeded
Details
cla/google All necessary CLAs are signed

@roberthbailey roberthbailey deleted the roberthbailey:cpp-watch-gameserver branch Aug 1, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants
You can’t perform that action at this time.