Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added sync.Map to backend and synchronizer #1078

Merged
merged 4 commits into from Jan 30, 2020
Merged

Added sync.Map to backend and synchronizer #1078

merged 4 commits into from Jan 30, 2020

Conversation

yfei1
Copy link
Collaborator

@yfei1 yfei1 commented Jan 30, 2020

This is an intermediate step to resolve #939. Leaving a bunch of TODOs in this PR and will fix them after the proto change.

@yfei1 yfei1 requested a review from Laremere January 30, 2020 01:47
Laremere
Laremere reviewed Jan 30, 2020
View reviewed changes
internal/app/synchronizer/synchronizer_service.go Outdated Show resolved Hide resolved
internal/app/synchronizer/synchronizer_service.go Outdated Show resolved Hide resolved
internal/app/synchronizer/synchronizer_service.go Outdated Show resolved Hide resolved
internal/app/synchronizer/synchronizer_service.go Outdated Show resolved Hide resolved
@yfei1 yfei1 requested a review from Laremere January 30, 2020 02:01
@yfei1 yfei1 merged commit edade67 into googleforgames:master Jan 30, 2020
@yfei1 yfei1 deleted the sync branch January 30, 2020 02:34
@yfei1 yfei1 mentioned this pull request Jan 30, 2020
Merged
@yfei1 yfei1 added this to the v0.9.0 milestone Jan 31, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Laremere Laremere Laremere approved these changes

Assignees
No one assigned
Labels
cla: yes
Projects
None yet
Milestone
v0.9.0
Development

Successfully merging this pull request may close these issues.

API change: Have evaluator return only match ids
3 participants
@yfei1 @Laremere @googlebot