Use hash of entries for merge key. #103
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
arostamianfar
suggested changes
Jan 31, 2018
Contributor
There was a problem hiding this comment.
Thanks! Let's run it on platinum genomes to ensure everything works as expected.
@bashir2 FYI, this would be a great candidate for the 'large' integration test based on platinum genomes.
| variant.reference_bases or '', | ||
| ','.join(variant.alternate_bases or [])]]) | ||
| hashlib.sha256(variant.reference_bases or '').hexdigest(), | ||
| hashlib.sha256(','.join(variant.alternate_bases or [])).hexdigest()]]) |
Contributor
There was a problem hiding this comment.
Consider making a private method _get_hash_key and use it here.
| variant.end or '', | ||
| variant.reference_bases or '', | ||
| ','.join(variant.alternate_bases or [])]]) | ||
| hashlib.sha256(variant.reference_bases or '').hexdigest(), |
Contributor
There was a problem hiding this comment.
I wonder if md5 is good enough here. 256 seems like an overkill :p
| def test_get_merge_keys(self): | ||
| strategy = move_to_calls_strategy.MoveToCallsStrategy(None, None, None) | ||
|
|
||
| empty_string_hash = hashlib.sha256('').hexdigest() |
Contributor
There was a problem hiding this comment.
Consider making a helper method here as well. I think it's ok to use the one in the private lib too.
nmousavi
force-pushed
the
hash-merge
branch
2 times, most recently
from
a162a85 to
30c6b03
Compare
Pull Request Test Coverage Report for Build 283
💛 - Coveralls |
Hash of reference_bases and alternate_bases is used for the merge key. fixes googlegenomics#102
Contributor
Author
|
Job finished successfully on platinum dataset. Thanks for the review! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hash of reference_bases and alternate_bases is used for the merge key.
fixes #102