From 1787396feb57b16b923bf5ab251e81d86ac22c24 Mon Sep 17 00:00:00 2001 From: Bashir Sadjad Date: Fri, 2 Mar 2018 14:20:36 -0500 Subject: [PATCH 1/2] Added an INFO message for the full command. --- gcp_variant_transforms/vcf_to_bq.py | 5 +++++ 1 file changed, 5 insertions(+) diff --git a/gcp_variant_transforms/vcf_to_bq.py b/gcp_variant_transforms/vcf_to_bq.py index 83afe8773..899f46da9 100644 --- a/gcp_variant_transforms/vcf_to_bq.py +++ b/gcp_variant_transforms/vcf_to_bq.py @@ -37,6 +37,7 @@ import datetime import enum import logging +import sys import tempfile import apache_beam as beam @@ -209,6 +210,10 @@ def _validate_args(options, parsed_args): def run(argv=None): """Runs VCF to BigQuery pipeline.""" + if argv: + logging.info('Command: %s', ' '.join(argv)) + else: + logging.info('Command: %s', ' '.join(sys.argv)) parser = argparse.ArgumentParser() parser.register('type', 'bool', lambda v: v.lower() == 'true') command_line_options = [option() for option in _COMMAND_LINE_OPTIONS] From cfba1bfb215e533924c04cdb66fa2f8ae874ecec Mon Sep 17 00:00:00 2001 From: Bashir Sadjad Date: Fri, 2 Mar 2018 14:36:10 -0500 Subject: [PATCH 2/2] review change --- gcp_variant_transforms/vcf_to_bq.py | 5 +---- 1 file changed, 1 insertion(+), 4 deletions(-) diff --git a/gcp_variant_transforms/vcf_to_bq.py b/gcp_variant_transforms/vcf_to_bq.py index 899f46da9..c8ce33abc 100644 --- a/gcp_variant_transforms/vcf_to_bq.py +++ b/gcp_variant_transforms/vcf_to_bq.py @@ -210,10 +210,7 @@ def _validate_args(options, parsed_args): def run(argv=None): """Runs VCF to BigQuery pipeline.""" - if argv: - logging.info('Command: %s', ' '.join(argv)) - else: - logging.info('Command: %s', ' '.join(sys.argv)) + logging.info('Command: %s', ' '.join(argv or sys.argv)) parser = argparse.ArgumentParser() parser.register('type', 'bool', lambda v: v.lower() == 'true') command_line_options = [option() for option in _COMMAND_LINE_OPTIONS]