diff --git a/.pylintrc b/.pylintrc index 57c9a5202..e1b44a627 100644 --- a/.pylintrc +++ b/.pylintrc @@ -121,6 +121,13 @@ disable = # OK as we don't call in all PTransforms. super-init-not-called, +[TYPECHECK] +generated-members = + # The transforms (e.g. Create) in beam declared in __all__ cannot be detected + # by pylint. + beam.*, + apache_beam.*, + [REPORTS] # Tells whether to display a full report or only the messages reports=no diff --git a/gcp_variant_transforms/transforms/partition_variants.py b/gcp_variant_transforms/transforms/partition_variants.py index 97eade3f6..5777bfdde 100644 --- a/gcp_variant_transforms/transforms/partition_variants.py +++ b/gcp_variant_transforms/transforms/partition_variants.py @@ -28,6 +28,6 @@ def __init__(self, partition): # type: (variant_partition.VariantPartition) -> None self._partition = partition - def partition_for(self, variant, num_partitions): + def partition_for(self, variant, _): # type: (vcfio.Variant, int) -> int return self._partition.get_partition(variant.reference_name, variant.start) diff --git a/gcp_variant_transforms/transforms/partition_variants_test.py b/gcp_variant_transforms/transforms/partition_variants_test.py index 04c8323db..0aec89c41 100644 --- a/gcp_variant_transforms/transforms/partition_variants_test.py +++ b/gcp_variant_transforms/transforms/partition_variants_test.py @@ -18,7 +18,7 @@ import unittest -from apache_beam import Partition +import apache_beam as beam from apache_beam.testing.test_pipeline import TestPipeline from apache_beam.testing.util import assert_that from apache_beam.testing.util import equal_to @@ -91,7 +91,7 @@ def test_partition_variants(self): partitions = ( pipeline | Create(variants) - | 'PartitionVariants' >> Partition( + | 'PartitionVariants' >> beam.Partition( partition_variants.PartitionVariants(partitioner), partitioner.get_num_partitions())) for i in xrange(partitioner.get_num_partitions()): diff --git a/gcp_variant_transforms/transforms/variant_to_bigquery_test.py b/gcp_variant_transforms/transforms/variant_to_bigquery_test.py index 965154abb..8587d5e0a 100644 --- a/gcp_variant_transforms/transforms/variant_to_bigquery_test.py +++ b/gcp_variant_transforms/transforms/variant_to_bigquery_test.py @@ -18,8 +18,8 @@ import unittest +import apache_beam as beam from apache_beam.io.gcp.internal.clients import bigquery -from apache_beam import ParDo from apache_beam.testing.test_pipeline import TestPipeline from apache_beam.testing.util import assert_that from apache_beam.testing.util import equal_to @@ -243,7 +243,7 @@ def test_convert_variant_to_bigquery_row(self): bigquery_rows = ( pipeline | Create([proc_var_1, proc_var_2, proc_var_3]) - | 'ConvertToRow' >> ParDo(ConvertVariantToRow( + | 'ConvertToRow' >> beam.ParDo(ConvertVariantToRow( self._row_generator))) assert_that(bigquery_rows, equal_to([row_1, row_2, row_3])) pipeline.run() @@ -257,7 +257,7 @@ def test_convert_variant_to_bigquery_row_omit_empty_calls(self): bigquery_rows = ( pipeline | Create([proc_var]) - | 'ConvertToRow' >> ParDo(ConvertVariantToRow( + | 'ConvertToRow' >> beam.ParDo(ConvertVariantToRow( self._row_generator, omit_empty_sample_calls=True))) assert_that(bigquery_rows, equal_to([row])) pipeline.run() @@ -272,7 +272,7 @@ def test_convert_variant_to_bigquery_row_allow_incompatible_recoreds(self): bigquery_rows = ( pipeline | Create([proc_var]) - | 'ConvertToRow' >> ParDo(ConvertVariantToRow( + | 'ConvertToRow' >> beam.ParDo(ConvertVariantToRow( self._row_generator, allow_incompatible_records=True))) assert_that(bigquery_rows, equal_to([row])) pipeline.run()