Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore!: remove library v3 #1137

Merged
merged 1 commit into from Jan 9, 2023
Merged

chore!: remove library v3 #1137

merged 1 commit into from Jan 9, 2023

Conversation

kikoso
Copy link
Collaborator

@kikoso kikoso commented Jan 6, 2023

This PR removes the V3 of the library.

Before submitting your PR, there are a few things you can do to make sure it goes smoothly:

  • Make sure to open a GitHub issue as a bug/feature request before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea
  • Ensure the tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
  • Appropriate docs were updated (if necessary)
  • Will this cause breaking changes to existing Java or Kotlin integrations? If so, ensure the commit has a BREAKING CHANGE footer so when this change is integrated a major version update is triggered. See: https://www.conventionalcommits.org/en/v1.0.0/

@kikoso kikoso added the type: cleanup An internal cleanup or hygiene concern. label Jan 6, 2023
@kikoso kikoso assigned wangela and unassigned barbeau Jan 6, 2023
@kikoso kikoso requested a review from wangela January 6, 2023 16:58
wangela
wangela requested changes Jan 6, 2023
View reviewed changes
README.md Outdated
@@ -32,7 +32,7 @@ You can view the generated [reference docs][javadoc] for a full list of classes
## Requirements

* Android API level 15+
* Maps SDK via Google Play Services ~OR (Deprecated) [Maps SDK v3 BETA] library~
* Maps SDK via Google Play Services OR [Maps SDK] library
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more. 

* [Maps SDK for Android](https://developers.google.com/maps/documentation/android-sdk/config) via Google Play Services

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please also delete L44-45 and other mentions of v3 in the README under ## Demo App

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more. 

* [Maps SDK for Android](https://developers.google.com/maps/documentation/android-sdk/config) via Google Play Services

Changed

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please also delete L44-45 and other mentions of v3 in the README under ## Demo App

I have left only the migration guide, which might make sense for users with the legacy artifact.

demo/build.gradle Show resolved Hide resolved
demo/build.gradle Show resolved Hide resolved
demo/src/gms/res/values/strings.xml
-->

<resources>
<string name="app_name">Maps Utils Demo (GMS)</string>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perhaps we should move this file to main and update the app name instead of deleting the file, as it's sought in https://github.com/googlemaps/android-maps-utils/blob/main/demo/src/main/AndroidManifest.xml#L26

@wangela wangela changed the title chore: remove library v3 chore!: remove library v3 Jan 6, 2023
@wangela
Copy link
Member

wangela commented Jan 6, 2023

Added ! to the PR title to indicate breaking change, but will need to manually add this to the squashed commit message.

@kikoso
Copy link
Collaborator Author

kikoso commented Jan 9, 2023

Added ! to the PR title to indicate breaking change, but will need to manually add this to the squashed commit message.

I have rebased from main and squashed all the commits into a single one with the exclamation symbol, let me know if this works out.

@wangela wangela merged commit 4038b7a into main Jan 9, 2023
@wangela wangela deleted the chore/remove_v3 branch January 9, 2023 18:33
wangela added a commit that referenced this pull request Jan 9, 2023
@wangela
fix: trigger major version release
15b90fe 
Update pull request template to request semantic commit prefixes for pull request titles.

BREAKING CHANGE: From #1137 merged as commit 4038b7a, removed v3 library
googlemaps-bot pushed a commit that referenced this pull request Jan 9, 2023
@semantic-release-bot
chore(release): 3.0.0 [skip ci]
c1bbe1d 
# [3.0.0](v2.4.1...v3.0.0) (2023-01-09)

### Bug Fixes

* trigger major version release ([15b90fe](15b90fe))

### BREAKING CHANGES

* From #1137 merged as commit 4038b7a, removed v3 library
@googlemaps-bot
Copy link
Contributor

🎉 This PR is included in version 3.0.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wangela wangela wangela approved these changes

Assignees

@wangela wangela

Labels
released type: cleanup An internal cleanup or hygiene concern.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@kikoso @wangela @googlemaps-bot @barbeau