Skip to content

Conversation

@barbeau
Copy link
Collaborator

@barbeau barbeau commented Mar 19, 2020

Reverts part of 7bbc3c7.

Hopefully fixes #668 (?)

Also, going forward we should probably bump the demo app dependency immediately after publishing the library release artifact to potentially catch issues like this.

Reverts part of 7bbc3c7 to restore this line

Fixes #668
@barbeau barbeau requested a review from arriolac March 19, 2020 19:51
@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Mar 19, 2020
@barbeau
Copy link
Collaborator Author

barbeau commented Mar 19, 2020

See #668 (comment):

Its definentely that commit. I examined the pom's downloaded by gradle for the two versions, and 1.0.0 and below have a "aar" tag, whereas 1.0.1 has a "pom" tag. So its definently an issue in the maven push. Hopefully re-adding that line is enough to fix it.

@arriolac
Copy link
Contributor

Yikes... thanks for fixing. I think this should do the trick as well. Let's push out 1.0.2 after this is merged.

@barbeau
Copy link
Collaborator Author

barbeau commented Mar 19, 2020

@arriolac Could we merge #665 prior to 1.0.2 as well?

@arriolac
Copy link
Contributor

@arriolac Could we merge #665 prior to 1.0.2 as well?

Yeah, let's merge that in, too.

@codecov
Copy link

codecov bot commented Mar 19, 2020

Codecov Report

Merging #669 into master will decrease coverage by 2.15%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #669      +/-   ##
==========================================
- Coverage   39.33%   37.18%   -2.16%     
==========================================
  Files          71       71              
  Lines        4037     4271     +234     
  Branches      606      662      +56     
==========================================
  Hits         1588     1588              
- Misses       2346     2580     +234     
  Partials      103      103              
Impacted Files Coverage Δ
...ndroid/clustering/view/DefaultClusterRenderer.java 0.00% <0.00%> (ø)
.../clustering/algo/PreCachingAlgorithmDecorator.java 0.00% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8689d29...dbf2dfa. Read the comment docs.

@barbeau barbeau merged commit bec98c2 into googlemaps:master Mar 19, 2020
@barbeau barbeau deleted the incl-sources branch March 19, 2020 20:35
@RoarGronmo
Copy link

Confirming that 1.0.2 is ok.

@barbeau
Copy link
Collaborator Author

barbeau commented Mar 20, 2020

@RoarGronmo Great, glad to hear it!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cla: yes This human has signed the Contributor License Agreement.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

GeoJson: Cannot resolve in 1.0.1

4 participants