feat: Support bidirectional cancellation for await* calls #43
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
google-cla
bot
added
the
cla: yes
arriolac
force-pushed
the
chris/feat/42
branch
2 times, most recently
from
ebceecd
to
ca71c85
Compare
BREAKING CHANGE: This alters the signature of all await* calls. Rather than taking in a fully built request, the new signatures require passing in a function literal receiver for the request builder object so that a `CancellableTokenSource` can be provided. Change-Id: I0372780bd0c96aa3df89c15b5d77855109155532
googlemaps-bot
pushed a commit
that referenced
this pull request
Jul 20, 2021
# [1.0.0](v0.4.0...v1.0.0) (2021-07-20) ### Bug Fixes * Enable multidex ([#44](#44)) ([f05fc22](f05fc22)) ### Features * Support bidirectional cancellation for await* calls ([#43](#43)) ([36b7279](36b7279)) ### BREAKING CHANGES * This alters the signature of all await* calls. Rather than taking in a fully built request, the new signatures require passing in a function literal receiver for the request builder object so that a `CancellableTokenSource` can be provided. Change-Id: I0372780bd0c96aa3df89c15b5d77855109155532
|
🎉 This PR is included in version 1.0.0 🎉 The release is available on:
Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Supporting bidirectional cancellation. This change modifies the
PlacesClient#await*calls such that all await methods on PlacesClient now take in a functional literal receiver of the request builder object rather than fully built requests.Fixes #42 🦕