Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: typo of PlacePhoto::photo_reference #347

Merged
merged 1 commit into from Mar 2, 2020
Merged

fix: typo of PlacePhoto::photo_reference #347

merged 1 commit into from Mar 2, 2020

Conversation

NickCis
Copy link
Contributor

@NickCis NickCis commented Feb 28, 2020

Before submitting your PR, there are a few things you can do to make sure it goes smoothly:

  • Make sure to open a GitHub issue as a bug/feature request before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea
  • Ensure the tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
  • Appropriate docs were updated (if necessary)

Fixes #346 馃

@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Feb 28, 2020
@NickCis NickCis changed the title Fix typo of PlacePhoto::photo_reference fix: typo of PlacePhoto::photo_reference Feb 28, 2020
@codecov
Copy link

codecov bot commented Feb 28, 2020

Codecov Report

Merging #347 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@          Coverage Diff          @@
##           master   #347   +/-   ##
=====================================
  Coverage     100%   100%           
=====================================
  Files          21     21           
  Lines         326    326           
  Branches       84     84           
=====================================
  Hits          326    326
Impacted Files Coverage 螖
src/common.ts 100% <酶> (酶) 猬嗭笍

Continue to review full report at Codecov.

Legend - Click here to learn more
螖 = absolute <relative> (impact), 酶 = not affected, ? = missing data
Powered by Codecov. Last update 9fa2a2f...8af5f9a. Read the comment docs.

@jpoehnelt jpoehnelt merged commit eaae9af into googlemaps:master Mar 2, 2020
@jpoehnelt
Copy link
Contributor

馃帀 This PR is included in version 2.1.2 馃帀

The release is available on:

Your semantic-release bot 馃摝馃殌

@NickCis NickCis deleted the patch-1 branch March 2, 2020 20:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla: yes This human has signed the Contributor License Agreement. released
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Places: findPlaceFromText photo typing has a typo
3 participants