Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Error in V8.patch #9

Closed
hotwinter opened this issue Mar 21, 2019 · 2 comments
Closed

Error in V8.patch #9

hotwinter opened this issue Mar 21, 2019 · 2 comments

Comments

@hotwinter
Copy link
Contributor

When applying the given v8 patch, it would result in the following error

../../src/d8.cc:2502:9: error: use of undeclared identifier 'success'
        success = false;

I think this line should be changed to

exception_was_thrown = true;

instead? Without this line, the Fuzzer would fail with

[Fuzzer] Cannot detect failed executions (exit code must be nonzero when an uncaught exception was thrown)
@saelo
Copy link
Collaborator

saelo commented Mar 21, 2019

Ah hm, what v8 version is that? In the one that I'm using (1ca088652d3aad04caceb648bcffef100bc4abc0) the variable seems to be called success: https://github.com/v8/v8/blob/1ca088652d3aad04caceb648bcffef100bc4abc0/src/d8.cc#L2968

@hotwinter
Copy link
Contributor Author

Ah...my bad, I used the one in the latest release, which I believe is 51df567dd66bdea870c9a93f445ee50b7bbd6735

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants