Cancelling google sign in on ios gives wrong error

[vonovak]

Describe your environment

• Device: iphone x simulator
• OS version: ios 13 sorry, it was 12.4
• SDK version: google sign in sdk 5.0.0 and 5.0.1
• [Android] Google Play Services version: not relevant

Describe the problem:

Canceling the sign in process leads to kGIDSignInErrorCodeUnknown instead of kGIDSignInErrorCodeCanceled. Please NOTE that I am able to sign in successfully if I don't cancel the flow.

Steps to reproduce:

1. integrate sign in
2. tap login in
3. tap cancel in the login modal (see 1st screenshot)
4. the delegate is called with wrong error (see 2nd screenshot)

Observed Results:

• the delegate is called with kGIDSignInErrorCodeUnknown

Expected Results:

• the delegate is called with kGIDSignInErrorCodeCanceled as covered in docs

Relevant Code:

// just use the sample app

[ayan2206]

same problem here

[capJavert]

I have the same problem.

[vonovak]

@samtstern you seem to be active around this repo, can you comment on this issue? Thanks

[casevictor]

hey 👋 got the same issue even using the new SDK 5.0.1

[samtstern]

Hi all! Sorry I have not been monitoring this repo closely but I will file a bug with the Google Sign In SDK folks ASAP and link them to this issue.

[samtstern]

For future reference, internal issue number 143211691

[gabriellet]

Thanks for filing this bug, my team has also encountered this issue. Is this a publicly available issue tracker? If so, can we get a link to this to track bug status/resolution?

[samtstern]

@gabriellet no it's not a publicly available issue tracker, I just provided the number in case you're discussing it with any other Googlers you can reference that and they can look it up. No updates at the moment.

[samtstern]

The team has confirmed that this is a regression beginning in 5.0.0 and will do a patch release soon to address it. Thanks for your patience everyone!

[casevictor]

Thanks for following up 👏