Resolver causing 0.8-0.9 MB of GC Allocations per frame in Editor

[benjaminOddGames]

I'm having an issue where the Resolver is causing a large amount of garbage every frame. This occurs in the editor including when not in play mode, and causes frequent stuttering caused by frequent garbage collections.

The version of Unity is 2018.2.5f1, with the latest Play Services Resolver.
The following profile screenshot was taken with Deep Profile and Profile Editor enabled.

Other computers in the studio do not have the same issue, though all are using the same version of Unity and Play Services Resolver.

Expanding the profiler gives the following info:

[stewartmiles]

Our code which reads the ABI to check for changes is getting hit each frame...

unity-jar-resolver/source/PlayServicesResolver/src/PlayServicesResolver.cs

Line 1106 in 16c9753

androidAbisPoller.Poll(AndroidAbis.Current, (previousValue, currentValue) => {

even though an action won't be triggered for a few seconds..

unity-jar-resolver/source/PlayServicesResolver/src/PlayServicesResolver.cs

Line 273 in 16c9753

public void Poll(T currentValue, Changed changed) {

Now we have RunOnMainThread, I guess this could be changed to batch up all property checks here

unity-jar-resolver/source/PlayServicesResolver/src/PlayServicesResolver.cs

Line 647 in 16c9753

RunOnMainThread.OnUpdate += PollBundleId;

to reduce the GC load.

[Nightro]

+1 - couple of us are suffering from this too

[VergilUa]

+1. Please fix this nonsense

[Ospanaattori]

The fact that this also takes ~10ms per frame on a decent PC is just not acceptable.

[stewartmiles]

Hi everyone, we know this is a problem and it's on the list of things we need to fix. Compared to some other issues we're not getting to it any time soon. So you have a couple of options:

• Send us a pull request with a fix.
• Turn off auto-resolution when you're not adding additional plugins to your project. Run Android Resolution when importing plugins that use Android libraries.

[oddgamesdaniel]

You're going to just ignore this massive issue? This issue is rendering the editor borderline unusable due to constant stutters, and causing our game to lock up in editor for well over 10-20 seconds when loading a new scene during play mode. Turning off auto resolution has zero impact on this issue.

[stewartmiles]

@oddgamesdaniel we're not ignoring this issue, it's just prioritized compared to the range of other issues that our team also has to deal with. Remember this plugin is open source, you're free to send us a pull request.

[oddgamesdaniel]

Pull request submitted. It isn't going to remove the underlying cause of the issue, but it should mean that anybody turning off auto resolution won't have to deal with the massive CG allocations every frame

[stewartmiles]

FYI folks, this is what I have working locally. It's down to about 200 bytes of allocation - which still seems a lot to me - every second rather than each frame.

[oddgamesdaniel]

Thank you, much appreciated!