Skip to content

Commit

Permalink
👔 up: update some for EnableLock options
Browse files Browse the repository at this point in the history
  • Loading branch information
inhere committed Jun 10, 2023
1 parent c020267 commit 51112f4
Show file tree
Hide file tree
Showing 5 changed files with 12 additions and 9 deletions.
2 changes: 1 addition & 1 deletion README.md
Original file line number Diff line number Diff line change
Expand Up @@ -122,7 +122,7 @@ will trigger the execution of the `dbListener1` listener.
- `**` matches any number of characters and can only be used at the beginning or end

```go
em := event.NewManager("test", event.UsePathMode, event.EnableLock)
em := event.NewManager("test", event.UsePathMode)
```

## Async fire events
Expand Down
2 changes: 1 addition & 1 deletion README.zh-CN.md
Original file line number Diff line number Diff line change
Expand Up @@ -121,7 +121,7 @@ func doUpdate() {
- `**` 则匹配任意多个字符,并且只能用于开头或结尾

```go
em := event.NewManager("test", event.UsePathMode, event.EnableLock)
em := event.NewManager("test", event.UsePathMode)
```

## 异步消费事件
Expand Down
8 changes: 5 additions & 3 deletions event.go
Original file line number Diff line number Diff line change
Expand Up @@ -44,7 +44,7 @@ type ManagerFace interface {

// Options event manager config options
type Options struct {
// EnableLock enable lock on fire event.
// EnableLock enable lock on fire event. default is TRUE.
EnableLock bool
// ChannelSize for fire events by goroutine
ChannelSize int
Expand All @@ -62,8 +62,10 @@ func UsePathMode(o *Options) {
}

// EnableLock enable lock on fire event.
func EnableLock(o *Options) {
o.EnableLock = true
func EnableLock(enable bool) OptionFn {
return func(o *Options) {
o.EnableLock = enable
}
}

// Event interface
Expand Down
1 change: 1 addition & 0 deletions manager.go
Original file line number Diff line number Diff line change
Expand Up @@ -56,6 +56,7 @@ func NewManager(name string, fns ...OptionFn) *Manager {
listenedNames: make(map[string]int),
}

em.EnableLock = true
// for async fire by goroutine
em.ConsumerNum = defaultConsumerNum
em.ChannelSize = defaultChannelSize
Expand Down
8 changes: 4 additions & 4 deletions manager_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -224,7 +224,7 @@ func TestManager_Fire_WithWildcard(t *testing.T) {

func TestManager_Fire_usePathMode(t *testing.T) {
buf := new(bytes.Buffer)
em := event.NewManager("test", event.UsePathMode, event.EnableLock)
em := event.NewManager("test", event.UsePathMode, event.EnableLock(true))

em.Listen("db.user.*", event.ListenerFunc(func(e event.Event) error {
_, _ = buf.WriteString("db.user.*|")
Expand Down Expand Up @@ -302,7 +302,7 @@ func TestManager_Fire_usePathMode(t *testing.T) {
}

func TestManager_Fire_AllNode(t *testing.T) {
em := event.NewManager("test", event.UsePathMode, event.EnableLock)
em := event.NewManager("test", event.UsePathMode, event.EnableLock(false))

buf := new(bytes.Buffer)
em.Listen("**.add", event.ListenerFunc(func(e event.Event) error {
Expand All @@ -318,7 +318,7 @@ func TestManager_Fire_AllNode(t *testing.T) {
}

func TestManager_FireC(t *testing.T) {
em := event.NewManager("test", event.UsePathMode, event.EnableLock)
em := event.NewManager("test", event.UsePathMode, event.EnableLock(true))
defer func(em *event.Manager) {
_ = em.Close()
}(em)
Expand Down Expand Up @@ -361,7 +361,7 @@ func TestManager_FireC(t *testing.T) {
}

func TestManager_Wait(t *testing.T) {
em := event.NewManager("test", event.UsePathMode, event.EnableLock)
em := event.NewManager("test", event.UsePathMode)

buf := new(bytes.Buffer)
em.Listen("db.user.*", event.ListenerFunc(func(e event.Event) error {
Expand Down

0 comments on commit 51112f4

Please sign in to comment.