Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

deprecated google/uid #27

Merged

Conversation

repejota
Copy link
Member

deprecated google/uid
using goombaio/guid

using goombaio/guid
@repejota repejota self-assigned this Oct 12, 2018
@repejota repejota merged commit e41768a into master Oct 12, 2018
@codecov
Copy link

codecov bot commented Oct 12, 2018

Codecov Report

Merging #27 into master will increase coverage by 0.25%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #27      +/-   ##
==========================================
+ Coverage   69.16%   69.42%   +0.25%     
==========================================
  Files           5        5              
  Lines         120      121       +1     
==========================================
+ Hits           83       84       +1     
  Misses         33       33              
  Partials        4        4
Impacted Files Coverage Δ
server/server.go 53.62% <ø> (ø) ⬆️
service/noop_service.go 100% <ø> (ø) ⬆️
service/noop_config.go 100% <100%> (ø) ⬆️
server/config.go 100% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3ad63db...266fb87. Read the comment docs.

@repejota repejota deleted the issue/26-deprecate-google-uid-in-favor-of-goombaio-guid branch October 12, 2018 00:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant