New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Flamethrower tgui #12316
Merged
ZeWaka
merged 11 commits into
goonstation:master
from
TobleroneSwordfish:flamethrower_tgui
Jan 1, 2023
Merged
Flamethrower tgui #12316
ZeWaka
merged 11 commits into
goonstation:master
from
TobleroneSwordfish:flamethrower_tgui
Jan 1, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TobleroneSwordfish
requested review from
mordent-goonstation and
ZeWaka
as code owners
December 6, 2022 16:39
keywordlabeler
bot
added
A-Game-Objects
The point of this PR is to deal with a specific game object
C-Feature
A new feature or enhancements to existing features
C-QoL
A quality of life improvement that makes the game easier to play
labels
Dec 6, 2022
boring-cyborg
bot
added
the
A-UI
Modifies UI in some way. Automatically applied on a change to tgui/
label
Dec 6, 2022
github-actions
bot
added
the
size/XL
Denotes a PR that changes 500-999 lines, ignoring generated files.
label
Dec 6, 2022
!merge_upstream |
Merging upstream failed: |
ghost
approved these changes
Dec 19, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not a coderdev however after testing this for a bit all seems to work properly. Very easy to use and I love the chem visualisation and temperature control.
github-actions
bot
added
the
S-Merge-Conflict
Applied and removed when a PR has or no longer has a merge conflict
label
Dec 20, 2022
ZeWaka
approved these changes
Jan 1, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
A-Game-Objects
The point of this PR is to deal with a specific game object
A-UI
Modifies UI in some way. Automatically applied on a change to tgui/
C-Feature
A new feature or enhancements to existing features
C-QoL
A quality of life improvement that makes the game easier to play
S-Merge-Conflict
Applied and removed when a PR has or no longer has a merge conflict
size/XL
Denotes a PR that changes 500-999 lines, ignoring generated files.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
[FEATURE] [QOL] [GAME OBJECTS]
About the PR
Adds a new TGUI component
ReagentBar
ripped out of the mechanical dropper UI and modifiesProgressBar
slightly to handle scaling better.Also standardizes
PortableHoldingTank
serialization.Thanks to Blackrep for design help!
Why's this needed?
TGUI good.
Changelog