Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix butchering #12471

Merged
merged 1 commit into from Dec 21, 2022
Merged

Fix butchering #12471

merged 1 commit into from Dec 21, 2022

Conversation

amylizzle
Copy link
Contributor

About the PR

A minor oversight meant all critters could be butchered, even when butcherable was FALSE.

Also I fixed a tiny runtime I found on sawflys with no AI

Also capybara butchering is now considered monstrous.

Changelog

(u)Amylizzle
(+)Some critters were butcherable when they shouldn't have been. If you find a critter that isn't butcherable but should be, report it as a bug.

@github-actions github-actions bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Dec 21, 2022
@amylizzle amylizzle added C-Bug A bug that impacts usage of a feature A-Game-Objects The point of this PR is to deal with a specific game object and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Dec 21, 2022
@NightmareChamillian
Copy link
Contributor

Ideally, I'd like sawflies to be butcherable for the sake of the poor janitors, just that they don't yield.... flesh. If you want, you can just drop the change for sawflies and I'll cook something up to fix it later today.

@amylizzle
Copy link
Contributor Author

It isn't specifically doing anything to sawflies, it just makes it respect butcherable. If you want sawflies to be butcherable, but produce something not meaty, you could add butcherable = TRUE to the sawfly mob and set meat_type to something sensible.

@Tarmunora Tarmunora merged commit c96d060 into goonstation:master Dec 21, 2022
github-actions bot pushed a commit that referenced this pull request Dec 21, 2022
@amylizzle amylizzle deleted the butcher_fix branch December 21, 2022 18:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-Game-Objects The point of this PR is to deal with a specific game object C-Bug A bug that impacts usage of a feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants