Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cog1 Upload Adjustments #13204

Merged
merged 4 commits into from Mar 8, 2023
Merged

Conversation

Wisemonster
Copy link
Contributor

@Wisemonster Wisemonster commented Feb 26, 2023

[MAPPING] [BALANCE]

About the PR

This pr remodels the Cog1 upload to be a bit more secure.

goonstation  maps_cogmap dmm  - StrongDMM 3_7_2023 1_00_48 PM

Why's this needed?

The current upload is rather insecure, especially with the lawrack being next to a wall. This aims to make the upload more secure, and a bit more risky to go into if the AI is rogue.

Changelog

(u)Wisemonster
(+)Cog1's Upload Chamber has been remodeled to be a bit more secure.

@boring-cyborg boring-cyborg bot added the A-Mapping A mapping change label Feb 26, 2023
@github-actions github-actions bot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Feb 26, 2023
@keywordlabeler keywordlabeler bot added the C-Balance Balance changes, buffs and nerfs label Feb 26, 2023
@flappybatpal
Copy link
Contributor

flappybatpal commented Feb 26, 2023

I'm not against the concept of moving it to the middle, as cog1 is getting rogued through the wall constantly on Classic right now but I don't think the glass and door should be removed.

@Wisemonster
Copy link
Contributor Author

I could re-add the thindows and thindow door, although it seems like we've been trying to phase out thindows/thindow doors, that's why I removed them.

@TobleroneSwordfish
Copy link
Contributor

TobleroneSwordfish commented Feb 26, 2023

The glass door section is weird, since it means that to access the turret controls you have to put yourself in a little airlocked section where you can be shot by lethal turrets and the AI can lock the door behind you, afaik no other map works like this.
Although since you've moved the turret controls outside it's probably fine to keep it.

@CheffieGithub
Copy link
Contributor

I was the one who suggested the thin stuff removal on discord mainly due to what was said about the turrets, and that the thindoor would make unrouging very easy

@Wisemonster
Copy link
Contributor Author

The glass door section is weird, since it means that to access the turret controls you have to put yourself in a little airlocked section where you can be shot by lethal turrets and the AI can lock the door behind you, afaik no other map works like this. Although since you've moved the turret controls outside it's probably fine to keep it.

Do you mean to keep the glass door and thindows? Do keep in mind that the windows can be unscrewed to act as makeshift barriers against the turrets if they are set to taser mode.

@CheffieGithub
Copy link
Contributor

I don't think Toblerone is saying to keep the thindows, reads more like a case against them. Also just a thought, perspective lights would be nice.

@Wisemonster
Copy link
Contributor Author

Alright, added perspective lights, but I had to move them down to prevent the right side's lights from overlapping with the intercom.

Copy link
Contributor

@Sord213 Sord213 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Screenshot_222
Could you fix the errant area (red X), and make it so the door is in the AI Upload area (yellow circle)

@Wisemonster Wisemonster requested a review from Sord213 March 8, 2023 18:10
@Sord213 Sord213 merged commit 629d190 into goonstation:master Mar 8, 2023
21 checks passed
github-actions bot pushed a commit that referenced this pull request Mar 8, 2023
Valtosin pushed a commit to frosty-dev/rugoon that referenced this pull request Apr 22, 2023
Valtosin pushed a commit to frosty-dev/rugoon that referenced this pull request Apr 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-Mapping A mapping change C-Balance Balance changes, buffs and nerfs size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants