Fixed inconsistent chaplain immunities #1341
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PrimeNumb
added
C-Balance
PrimeNumb
commented
Jul 4, 2020
Tarmunora
reviewed
Jul 4, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
About the PR
There were some spells and abilities from both vampires and wizards that still worked on the chaplain, despite the chaplain being regarded as the only person immune to supernatural and magical abilities. This PR makes it so the chaplain - in addition to existing immunities - is also protected from:
Do note that Fireball can still do splash damage.
Why's this needed?
The chaplain was the only person on the station immune to supernatural and magical abilities, and the previously mentioned inconsistent protection from these abilities was unintuitive; players would have no idea which abilities worked and which abilities didn't outside trial and error.
Changelog