Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Documents and tweaks term_ping filtering option #4002

Merged
merged 2 commits into from Mar 16, 2021
Merged

Documents and tweaks term_ping filtering option #4002

merged 2 commits into from Mar 16, 2021

Conversation

penny64
Copy link
Contributor

@penny64 penny64 commented Mar 13, 2021 •
edited

[QOL]

About the PR

This documents the term_ping filtering functionality in the TermOS help command, and adjusts it so that it accepts the first argument as the filter- not the second

Old

term_ping asdf PNET_MAINFRAME

New

term_ping PNET_MAINFRAME

Why's this needed?

Documentation of features in game is good, and taking the first argument is consistent with the other commands like connect
I'm not sure taking the second argument was ever actually intended.

Changelog

(u)Penny
(+)The term_ping command now accepts a filter as the first option
(+)The TermOS help command now documents the term_ping filter

@keywordlabeler keywordlabeler bot added the C-QoL A quality of life improvement that makes the game easier to play label Mar 13, 2021
ZeWaka
ZeWaka approved these changes Mar 14, 2021
View reviewed changes
Copy link
Member

@ZeWaka ZeWaka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks for doing this!

code/modules/networks/computer3/terminal.dm Outdated Show resolved Hide resolved
@penny64
Copy link
Contributor Author

penny64 commented Mar 14, 2021

Glad to help! I don't need to do anything on behalf of your changes right @ZeWaka ?

@ZeWaka
Copy link
Member

ZeWaka commented Mar 14, 2021

nop!

@ZeWaka ZeWaka merged commit 0b3579f into goonstation:master Mar 16, 2021
github-actions bot pushed a commit that referenced this pull request Mar 16, 2021
@robuddybot
Changelog for #4002 [skip ci]
4bf605b
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ZeWaka ZeWaka ZeWaka approved these changes

Assignees
No one assigned
Labels
C-QoL A quality of life improvement that makes the game easier to play
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@penny64 @ZeWaka