Unhardcode server-pick input lists in bans #6302
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pali6
added
the
C-Code-Quality
github-actions
bot
added
the
size/M
ZeWaka
reviewed
Oct 15, 2021
| pick_list["All"] = "all" | ||
| for(var/id in src.servers) | ||
| var/datum/game_server/server = src.servers[id] | ||
| if(public_only && !server.publ) |
There was a problem hiding this comment.
i was really confused on what pub1 was until i realized it said publ for public - do we really need to be saving two characters for this
There was a problem hiding this comment.
Compiler/linter yells that public is a reserved word if you use public.
There was a problem hiding this comment.
I guess I could name it is_public? Here's the error that DM yells about btw
There was a problem hiding this comment.
Out of the scope of this PR however. 😌
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
About the PR
Replaces hardcoded lists of servers when (job)banning people with lists generated from the new
/datum/game_serversobject. As a side effect this allows per-server banning on Nightshade servers etc.Note that this depends on goonhub actually supporting this per-server banning of Nightshade. I assume that's supported but am not sure.
Why's this needed?
Hardcoding stuff is bad because when a new server gets added etc. we'd have to modify all those hardcoded occurences manually instead of modifying the central config.
Changelog
No changelog.