Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

command completion insufficient in MSYS #1053

Closed
tsuyoshicho opened this issue Feb 1, 2019 · 1 comment

Comments

@tsuyoshicho
Copy link

commented Feb 1, 2019

Summary

Use completion in git bash

see below

$ gopass completion bash
_gopass_bash_autocomplete() {
     local cur opts base
     COMPREPLY=()
     cur="${COMP_WORDS[COMP_CWORD]}"
     opts=$( ${COMP_WORDS[@]:0:$COMP_CWORD} --generate-bash-completion )
     local IFS=$'\n'
     COMPREPLY=( $(compgen -W "${opts}" -- ${cur}) )
     return 0
 }

complete -F _gopass_bash_autocomplete gopass.exe

When command gopass typed, do no complete.
Because gopass is not gopass.exe

Steps To Reproduce

Work in MSYS and completion setting

Expected behavior

gopass support completion.

complete -F _gopass_bash_autocomplete gopass
complete -F _gopass_bash_autocomplete gopass.exe

Request : Windows specific two completion define output.

Environment

  • OS: Windows any
  • OS version: -
  • gopass Version: gopass 1.8.4
  • Installation method: choco install gopass

Additional context

@dominikschulz dominikschulz self-assigned this Feb 24, 2019
@dominikschulz dominikschulz added the bug label Feb 24, 2019
@dominikschulz dominikschulz added this to the 1.8.5 - Bugfix release milestone Feb 24, 2019
dominikschulz added a commit to dominikschulz/gopass that referenced this issue Feb 24, 2019
dominikschulz added a commit to dominikschulz/gopass that referenced this issue Feb 24, 2019
Fixes gopasspw#1053

Signed-off-by: Dominik Schulz <dominik.schulz@gauner.org>
dominikschulz added a commit that referenced this issue Feb 24, 2019
Fixes #1053

Signed-off-by: Dominik Schulz <dominik.schulz@gauner.org>
@tsuyoshicho

This comment has been minimized.

Copy link
Author

commented Feb 25, 2019

Thank you for your fix.

I try it after release.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.