-
-
Notifications
You must be signed in to change notification settings - Fork 479
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
selection dialog hangs on FreeBSD wiht go >=1.13 #1226
Comments
|
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. |
|
Bump issue as i get more and more reports from people using the FreeBSD port about this |
|
Seems to work for me now when building from ports. The port does have a few patches now. |
|
Yes, we committed a patch based on my ugly hack described in this ticket. This works for now but also replaces termbox-go with tcell/termbox. Going forward this might not be compatible with future versions, so a fix in the project would be preferable. |
Fixes gopasspw#1326 Fixes gopasspw#1226 RELEASE_NOTES=[BUGFIX] Remove curses UI. Signed-off-by: Dominik Schulz <dominik.schulz@gauner.org>
Fixes gopasspw#1326 Fixes gopasspw#1226 RELEASE_NOTES=[BUGFIX] Remove curses UI. Signed-off-by: Dominik Schulz <dominik.schulz@gauner.org>
Fixes gopasspw#1326 Fixes gopasspw#1226 RELEASE_NOTES=[BUGFIX] Remove curses UI. Signed-off-by: Dominik Schulz <dominik.schulz@gauner.org>
Summary
The secret selection screen hangs, cursor movement or cancelation do not work, and has to be killed.
Steps To Reproduce
When opening the selection dialog with
gopass searchstringthe selection screen is drawn and then hangs and must be killed.Expected behavior
Entries can be selected from the list or the dialog can be canceled
Environment
OS: FreeBSD 12.1
gopass: 1.8.6
golang: 1.13.5
Compiled from source
Additional context
I did alot of tests and could narrow it down to the following:
Compiling gopass with go 1.12.x results in a working dialog but compiling with go >= 1.13 exhibits the faulty behaviour. The culprit seems to be termbox-go which in turn is used by gocui. It depends heavily on the syscall package which has been deprecated by the go team in favour of x/sys/unix.
It seems to hang in the mainloop when waiting for SIGIO events. As the termbox-go README states the package is now "somewhat unmaintained" so opening a bug report there may not result in a fix. The gocui package also seems to be unmaintained as the last commit is from April, 2018.
I tried a dirty hack by replacing the termbox-go dependency in gocui with github.com/gdamore/tcell/termbox which then also results in a working dialog.
As a side note: The github binary release works. I think it may be build with golang <1.13?
The text was updated successfully, but these errors were encountered: