Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

go build error with go 1.13 #1182

Merged
merged 1 commit into from Oct 20, 2019
Merged

go build error with go 1.13 #1182

merged 1 commit into from Oct 20, 2019

Conversation

cljoly
Copy link
Contributor

@cljoly cljoly commented Sep 21, 2019

I had troubles building gopass with go 1.13. For instance, with an empty GOPATH, doing a go get github.com/gopasspw/gopass works. But with go build in $GOPATH/src/github.com/gopasspw/gopass/, I get

go: github.com/mgechev/revive@v0.0.0-20190726005920-de49a7b6832f requires
	github.com/mgechev/dots@v0.0.0-20190603122614-18fa4c4b71cc: invalid pseudo-version: does not match version-control timestamp (2018-12-28T16:47:30Z)

This may be related to stricter module validation (“The go command now verifies the mapping between pseudo-versions and version-control metadata”) in go 1.13.
So I just updated revive to its current master.

I ran make test and make test-integration (both successfully). However, make codequality returns:

     STATICCHECK /usr/lib/go/src/unicode/utf8/utf8.go:28:8: expected ';', found b00000000 (and 10 more errors)
couldn't load packages due to errors: golang.org/x/net/http/httpproxy, golang.org/x/crypto/nacl/secretbox, text/template and 65 more
make: *** [Makefile:173: codequality] Error 1

Signed-off-by: Clément Joly <oss@171819.xyz>
Copy link
Member

@dominikschulz dominikschulz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dominikschulz dominikschulz merged commit 49a3bad into gopasspw:master Oct 20, 2019
@cljoly cljoly deleted the go113 branch October 20, 2019 21:01
kpitt pushed a commit to kpitt/gopass that referenced this pull request Jul 21, 2022
Signed-off-by: Clément Joly <oss@171819.xyz>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants