go build error with go 1.13 #1182
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I had troubles building gopass with go 1.13. For instance, with an empty GOPATH, doing a
go get github.com/gopasspw/gopassworks. But withgo buildin$GOPATH/src/github.com/gopasspw/gopass/, I getThis may be related to stricter module validation (“The go command now verifies the mapping between pseudo-versions and version-control metadata”) in go 1.13.
So I just updated revive to its current master.
I ran
make testandmake test-integration(both successfully). However,make codequalityreturns: