Repository navigation
Conversation
cljoly
force-pushed
the
old-pass-simple
branch
3 times, most recently
from
November 17, 2019 21:45
f2cfdc0 to
40bbe36
Compare
cljoly
force-pushed
the
old-pass-simple
branch
from
December 30, 2019 11:33
40bbe36 to
58fe0c0
Compare
|
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. |
This is mostly level 1 described in gopasspw#928 (comment) This is heavily inspired from pkg/action/history.go and pkg/action/hibp.go Signed-off-by: Clément Joly <oss@131719.xyz>
cljoly
marked this pull request as draft
April 26, 2020 13:39
Member
|
This PR seems to be incomplete and had no recent progress. |
Contributor
Author
|
Yes, I spent time figuring out how to add tests… |
Member
|
Feel free to reopen if you have time to rebase. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is mostly level 1 described in
#928 (comment)
TODO: