Skip to content

Add subcommand to audit to list old password - #1212

Closed
cljoly wants to merge 1 commit into
gopasspw:masterfrom
cljoly:old-pass-simple
Closed

cljoly wants to merge 1 commit into
gopasspw:masterfrom
cljoly:old-pass-simple

Conversation

@cljoly

@cljoly cljoly commented Nov 17, 2019

Copy link
Copy Markdown
Contributor

This is mostly level 1 described in
#928 (comment)

TODO:

  • Make existing test pass
  • Add tests
  • Update a documentation somewhere?

@cljoly
cljoly force-pushed the old-pass-simple branch 3 times, most recently from f2cfdc0 to 40bbe36 Compare November 17, 2019 21:45
@stale

stale Bot commented Mar 29, 2020

Copy link
Copy Markdown

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale Bot added the wontfix label Mar 29, 2020
This is mostly level 1 described in
gopasspw#928 (comment)

This is heavily inspired from pkg/action/history.go and
pkg/action/hibp.go

Signed-off-by: Clément Joly <oss@131719.xyz>
@stale stale Bot removed the wontfix label Mar 29, 2020
@cljoly
cljoly marked this pull request as draft April 26, 2020 13:39
@cljoly cljoly changed the title WIP: Add subcommand to audit to list old password Add subcommand to audit to list old password Apr 26, 2020
@dominikschulz

Copy link
Copy Markdown
Member

This PR seems to be incomplete and had no recent progress.
Also I don't want ot add even more subcommands.
But we'll consider adding an age check to the regular audit command.
This will be tracked in #928

@cljoly

cljoly commented May 23, 2020

Copy link
Copy Markdown
Contributor Author

Yes, I spent time figuring out how to add tests…

@dominikschulz

Copy link
Copy Markdown
Member

Feel free to reopen if you have time to rebase.
But in that case please avoid adding a new subcommand.
I'd rather have this check added to the default audit checks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants