Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Editing while reading #890

Merged
merged 15 commits into from Aug 11, 2018

Conversation

@jean
Copy link
Contributor

commented Jul 1, 2018

No description provided.

@codecov-io

This comment has been minimized.

Copy link

commented Jul 1, 2018

Codecov Report

Merging #890 into master will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #890   +/-   ##
=======================================
  Coverage   63.77%   63.77%           
=======================================
  Files         170      170           
  Lines        9800     9800           
=======================================
  Hits         6249     6249           
  Misses       2771     2771           
  Partials      780      780
Impacted Files Coverage Δ
commands.go 90.44% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 07625cd...a1cc998. Read the comment docs.

@dominikschulz dominikschulz self-requested a review Aug 8, 2018
@dominikschulz

This comment has been minimized.

Copy link
Contributor

commented Aug 8, 2018

Thanks a lot. The change looks good, but could you please add a "Signed-Off" line to your commit(s)? Thanks!

Copy link
Contributor

left a comment

LGTM

@jean jean force-pushed the jean:master branch from 3a64975 to 59d6a09 Aug 9, 2018
jean added 13 commits Jul 1, 2018
Signed-off-by: Jean Jordaan <jean.jordaan@gmail.com>
Signed-off-by: Jean Jordaan <jean.jordaan@gmail.com>
Signed-off-by: Jean Jordaan <jean.jordaan@gmail.com>
Signed-off-by: Jean Jordaan <jean.jordaan@gmail.com>
Signed-off-by: Jean Jordaan <jean.jordaan@gmail.com>
Signed-off-by: Jean Jordaan <jean.jordaan@gmail.com>
Signed-off-by: Jean Jordaan <jean.jordaan@gmail.com>
Signed-off-by: Jean Jordaan <jean.jordaan@gmail.com>
Signed-off-by: Jean Jordaan <jean.jordaan@gmail.com>
Signed-off-by: Jean Jordaan <jean.jordaan@gmail.com>
Signed-off-by: Jean Jordaan <jean.jordaan@gmail.com>
Signed-off-by: Jean Jordaan <jean.jordaan@gmail.com>
Signed-off-by: Jean Jordaan <jean.jordaan@gmail.com>
@jean jean force-pushed the jean:master branch from 59d6a09 to ef7655d Aug 9, 2018
@jean

This comment has been minimized.

Copy link
Contributor Author

commented Aug 9, 2018

@dominikschulz added sign-off, I see the build is failing now on master also?

@dominikschulz

This comment has been minimized.

Copy link
Contributor

commented Aug 10, 2018

Thanks! I'll check the builds for master.

@dominikschulz dominikschulz merged commit 393dd03 into gopasspw:master Aug 11, 2018
3 checks passed
3 checks passed
DCO All commits have a DCO sign-off from the author
Details
codecov/project 63.77% (+0%) compared to 07625cd
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@dominikschulz dominikschulz added this to the 1.8.3 - Bugfix release milestone Nov 19, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.